Add Tests for VTI Software Pressure Control Functionality #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
22 tasks
LilithCole
requested changes
Sep 20, 2022
This isn't present on the flowchart. Actually added in by the script v3 update. There was an issue where the system was unable to cool if the actual temp was high above the cutoff. Now takes both into account. Now takes both the sp and the actual temp into account.
The command to run them all was getting a bit long and annoying.
RE #
cailafinn
force-pushed
the
TICKET6947_auto_cryo_ctrl
branch
from
15a3a03 to
3e90ccc
Compare
LilithCole
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some tests to cover the new pressure control work.
Part of this also includes refactoring the test classes to keep everything manageable and reduce test runtimes for devs, especially when you don't need to run the whole parameterised set.
Partially Resolves ISISComputingGroup/IBEX#6947