Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryogenics: Implement the Enhanced Cryostat Control as IOC logic #6947

Assignees
Labels

Comments

@KathrynBaker
Copy link
Member

KathrynBaker commented Dec 23, 2021

As someone using cryogenics at ISIS (especially on EMU) I need enhanced cryostat control scripts, so that systems running under pressure control will heat and cool automatically to the desired temperature, automatically adjusting the gas flow and heater for optimal running.

Acceptance Criteria

  • The python test script is enacted at the IOC level
  • There is a desire to supply the definition of the pressure law as a Python function
    • Implemented as a linear interpolation using a text file similar to eurotherm ramp files.
  • The following values should be user configurable:
    • CUTOFF_POINT in Kelvin
    • PRESSURE_SETPOINT_MIN in mbar
    • PRESSURE_SETPOINT_MAX in mbar
    • CONSTANT_PRESSURE_VALUE in mbar
    • DELAY_BETWEEN_SETS in ms
    • TEMP_SCALE
    • PRESSURE_SET_BLOCK
    • TEMP_BLOCK
    • TEMP_SET_BLOCK
  • PID values for the Mercury Pressure Control need to be sent to the device and managed in a similar fashion to the TPAR files
    • This is being implemented as a separate ticket.
  • Find a way to disambiguate this clearly from the LBC logic as they are both doing very similar things (controlling NV pressure based on temperature)
  • Ensure this logic and the "little blue cryostat" are mutually exclusive with each other

Notes

To Review

@KathrynBaker
Copy link
Member Author

Original content of the ticket:

As someone using cryogenics at ISIS (especially on EMU) I need enhanced cryostat control scripts, so that systems running under pressure control will heat and cool automatically to the desired temperature, automatically adjusting the gas flow and heater for optimal running.

Acceptance Criteria

Notes

@cailafinn cailafinn self-assigned this Aug 9, 2022
@github-actions github-actions bot added in progress and removed ready labels Aug 9, 2022
@Tom-Willemsen
Copy link
Contributor

Clarification from cryogenics, this needs to be separate (but mutually exclusive with) the little blue cryostat logic. I've added the following acceptance criteria to the ticket:

  • Find a way to disambiguate this clearly from the LBC logic as they are both doing very similar things (controlling NV pressure based on temperature)
  • Ensure this logic and the "little blue cryostat" are mutually exclusive with each other

@cailafinn
Copy link
Contributor

cailafinn commented Aug 12, 2022

Additional info from cryo seems to suggest that the LBC cryostat is a "Flow" type and the ones for EMU/Muon are "VTI" type. This seems like a potentially good way to differenciate the logic

@LilithCole
Copy link
Contributor

Couple of things I wasn't clear on from design docs and a problem running tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment