995x - Signposting fixes #9955
Merged
995x - Signposting fixes #9955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added
the
Feature: Signposting
pdurbin
reviewed
Sep 26, 2023
pdurbin
reviewed
Oct 3, 2023
There was a problem hiding this comment.
There's a failing test:
java.lang.NullPointerException: Cannot invoke "jakarta.json.JsonArray.getJsonObject(int)" because the return value of "jakarta.json.JsonObject.getJsonArray(String)" is null
at edu.harvard.iq.dataverse.api.SignpostingIT.testSignposting(SignpostingIT.java:96)
janvanmansum
added a commit
to janvanmansum/dataverse
that referenced
this pull request
Oct 11, 2023
This was referenced Oct 11, 2023
janvanmansum
added a commit
to DANS-KNAW/dataverse
that referenced
this pull request
Oct 11, 2023
janvanmansum
added a commit
to DANS-KNAW/dataverse
that referenced
this pull request
Oct 12, 2023
* Applied IQSS#9984 * Merge IQSS#9955 --------- Co-authored-by: Jan van Mansum <[email protected]> Co-authored-by: Jan van Mansum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This addresses several issues raised by the community in signposting - two related to the format of output that wasn't per the spec, one regarding the mimetype used for a link, and one to avoid a potential issue where auto-updates of the page were failing in 5.14. (For the last one, it appears that 6.0 offers a fix. The fixes here will assure if workingversion == null for signposting occurs, it will not result in an exception that stops processing. They also add a check to make sure the versionId is set in the DatasetPage.refresh method, which was the problem in v5.14 as described in #9954.)
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: For the first two, read the issue and assure that the output now matches, i.e. <> chars exist in the license line and calling the linkset api doesn't return a linkset object as a child of a "data" json object. For the third, verify the mimetype used for the link in the issue is application/ld_json and verify the curl command in the issue - changed to use the new mimetype - works. For the last - as of now, regression testing that publishing a dataset works with the page finally updating to the published version is all we can do in 6.x. This is because 6.0 has changes that fix the known test cases and we don't know if the problem still exists in 6.x (with the fixes, if the problem does occur, we'll get waning messages in the log rather than having the dataset page display/refresh fail). FWIW, I did verify that the fixes here worked/works at QDR prior to the 6.0 fix.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: added.
Additional documentation: