Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signposting Authors links issues #9940

Closed
luddaniel opened this issue Sep 20, 2023 · 2 comments · Fixed by #9941
Closed

Signposting Authors links issues #9940

luddaniel opened this issue Sep 20, 2023 · 2 comments · Fixed by #9941
Labels
Feature: Signposting Typed links in headers, etc. https://signposting.org pm.GREI-d-2.4.1B NIH AIM:4 YR:2 TASK:1B | 2.4.1B | (started yr1) Resolve OAI-PMH harvesting issues Type: Bug a defect User Role: API User Makes use of APIs
Milestone

Comments

@luddaniel
Copy link
Contributor

Hello there,

By working on Signposting parameters (dataverse.signposting.level1-author-limit and dataverse.signposting.level1-item-limit) and crawling the Java code, we found 2 issues :

  • When author type and identifier fields are correctly filled, level 1 does not display a correct link
    Ex: Given type=ORCID and idvalue=0000-0002-3202-0263 it prints Link: <0000-0002-3202-0263>;rel="author" instead of Link: <https://orcid.org/0000-0002-3202-0263>;rel="author"
  • When you have more authors than the limit, level 2 does not display links for authors and it should display them all unlike level 1

Also there is comment //If no type and there's a value, assume it is a URL (is this reasonable?) : I would say that it's reasonable if it's a valid URL. As FAIR Signposting Profile suggest it must be a link and looks at the end at least like "http(s)://(domain)/(author-id)" not only "(author-id)".

PR is already done.

luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Sep 20, 2023
@pdurbin pdurbin added Type: Bug a defect User Role: API User Makes use of APIs Feature: Signposting Typed links in headers, etc. https://signposting.org labels Oct 7, 2023
@cmbz cmbz moved this to Release 6.1 Proposals in IQSS Dataverse Project Oct 11, 2023
@cmbz cmbz added the pm.GREI-d-2.4.1B NIH AIM:4 YR:2 TASK:1B | 2.4.1B | (started yr1) Resolve OAI-PMH harvesting issues label Oct 11, 2023
@qqmyers
Copy link
Member

qqmyers commented Dec 13, 2023

@cmbz - there is already a PR awaiting prioritization for this issue: #9941

@cmbz
Copy link

cmbz commented Dec 13, 2023

stevenwinship added a commit that referenced this issue Jan 22, 2024
…g_authors_links

#9940 - fixed various issues with generated urls of authors for signposting
@pdurbin pdurbin added this to the 6.2 milestone Jan 22, 2024
@DS-INRAE DS-INRAE moved this to Done in Recherche Data Gouv Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Signposting Typed links in headers, etc. https://signposting.org pm.GREI-d-2.4.1B NIH AIM:4 YR:2 TASK:1B | 2.4.1B | (started yr1) Resolve OAI-PMH harvesting issues Type: Bug a defect User Role: API User Makes use of APIs
Projects
Status: Done
4 participants