-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6634 primefaces8 #6804
6634 primefaces8 #6804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There were a couple of stray duplicate imports of the PF uploadedFile, but I took them out.
Issues found so far:
|
For #2, since it also seems to happen on dev, doesn't seem to be PF8 related, specifically. Regardless, we've decided to remove this component completely for a better designed solution (#6772). So I don't think it's worth the effort to fix as it will be gone soon - that issue is in the Up Next column and should be complete before the next release. I'll copy over the report to that issue, just so we can track, it there if need be. |
@scolapasta I'm going to merge this since all functional stuff is working but there is that one extra logging issue, which I'll open as a separate ticket. |
What this PR does / why we need it:
Upgrades Primefaces to the latest v8.
Which issue(s) this PR closes:
Closes #6634
Closes #6557
Special notes for your reviewer:
changes were surgical and are due to changes in primefaces APIs or moving some popup code
Suggestions on how to test this:
Smoke / regression tests; no new functionality. (though upload component now allows files without extension, so that should be tested in order to close #6557)
Does this PR introduce a user interface change?:
no (except in allowing users to upload files without extensions)
Is there a release notes update needed for this change?:
Might be worth mentioning the upgrade, but nothing special needs to be done.
Additional documentation: