Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6634 primefaces8 #6804

Merged
merged 17 commits into from
Apr 17, 2020
Merged

6634 primefaces8 #6804

merged 17 commits into from
Apr 17, 2020

Conversation

scolapasta
Copy link
Contributor

@scolapasta scolapasta commented Apr 9, 2020

What this PR does / why we need it:
Upgrades Primefaces to the latest v8.

Which issue(s) this PR closes:

Closes #6634
Closes #6557

Special notes for your reviewer:
changes were surgical and are due to changes in primefaces APIs or moving some popup code

Suggestions on how to test this:
Smoke / regression tests; no new functionality. (though upload component now allows files without extension, so that should be tested in order to close #6557)

Does this PR introduce a user interface change?:
no (except in allowing users to upload files without extensions)

Is there a release notes update needed for this change?:
Might be worth mentioning the upgrade, but nothing special needs to be done.

Additional documentation:

@coveralls
Copy link

coveralls commented Apr 9, 2020

Coverage Status

Coverage remained the same at 19.661% when pulling e9e186b on 6634-primefaces8 into e5413e2 on develop.

@sekmiller sekmiller self-assigned this Apr 9, 2020
Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There were a couple of stray duplicate imports of the PF uploadedFile, but I took them out.

@kcondon kcondon self-assigned this Apr 14, 2020
@kcondon
Copy link
Contributor

kcondon commented Apr 16, 2020

Issues found so far:
x1. Uploading 3 files to s3 direct causes file upload to not complete, no errors, progress bars stuck.
Update: This appears to be an intermittent/timing? issue with direct to s3 on dataset create. Will do further testing and open a new ticket. Happens on develop too.
x2. Host Dataverse type ahead/lookup logic not working after lookup failure/correction on create dataset page. Does not try again. Update: This is now also broken on develop branch, was working recently.
3. On dataset create, flurry of server log entries (6) of this type:
this also happens when click log on.

[2020-04-16T15:15:15.184-0400] [glassfish 4.1] [WARNING] [jsf.externalcontext.no.mime.type.found] [javax.enterprise.resource.webcontainer.jsf.context] [tid: _ThreadID=150 _ThreadName=jk-connector(3)] [timeMillis: 1587064515184] [levelValue: 900] [[
  JSF1091: No mime type could be found for file bs/css/bootstrap.min.css.map.  To resolve this, add a mime-type mapping to the applications web.xml.]]

@scolapasta
Copy link
Contributor Author

For #2, since it also seems to happen on dev, doesn't seem to be PF8 related, specifically. Regardless, we've decided to remove this component completely for a better designed solution (#6772). So I don't think it's worth the effort to fix as it will be gone soon - that issue is in the Up Next column and should be complete before the next release.

I'll copy over the report to that issue, just so we can track, it there if need be.

@kcondon
Copy link
Contributor

kcondon commented Apr 17, 2020

@scolapasta I'm going to merge this since all functional stuff is working but there is that one extra logging issue, which I'll open as a separate ticket.

@kcondon kcondon merged commit 1e25514 into develop Apr 17, 2020
@kcondon kcondon deleted the 6634-primefaces8 branch April 17, 2020 11:48
@djbrooke djbrooke added this to the Dataverse 5 milestone Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to PrimeFaces 8 Cannot upload files without extensions
5 participants