-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typeahead widget on Link Dataset popup is slow and doesn't display all options as expected #6772
Comments
Possibly related to #6754 |
In the design meeting we discussed addressing this in two ways:
For #2, the idea is that Harvard or other open installation users, who can deposit to Root, see the option to change the default Dataverse and add a template in a new block, below. "Edit" will open a popup (see mockup below). We need further discussion to figure out what happens for installations who's users can not add to the Root dataverse. We discussed that the Add Data button should not appear in the header for installations who's users who can not add to Root (related to #6708). There are 4 user states that relate to the Add Data button in the header. We need to figure out how those states relate to and might affect this proposed approach.
|
FWIW, #2 is fine for any installation - you just wouldn't see the root amongst und your options. |
One minor drawback to this - if you can only deposit to one dataverse (say you are new on Harvard dataverse, so can only deposit to the root), then you would go to the popup and see no more than the one result. i.e. nothing to change to. (and we can't do something like only show the edit if you can multiple, because then we're back to the having to check every dataverse issue) |
|
@scolapasta I think we can live with the drawback, especially if we can show results without running the search. |
While this component is going away with the proposed solution, I just want to add that @kcondon ran into another issue while testing PF8 (not related specifically to PF8): "Host Dataverse type ahead/lookup logic not working after lookup failure/correction on create dataset page. Does not try again. Update: This is now also broken on develop branch, was working recently." |
To follow up on the above comment, the issue appears to be with individual dv's rather than root, where "Dataverse" is added to the name. If you removed "Dataverse" on the edit dataset page, the lookup begins working again. This quirk does not happen with root dv. |
In scope for this issue:
Other instances with type ahead:
|
We reviewed work in progress, and agreed to pause this effort. Proposed solutions add complexity. We are interested in looking into different approaches, for example, what if users create a dataverse or dataset first, and then associate it with a dataverse? Discussed:
|
Ideally we want to use a typeahead/dropdown for users to select a dataset and dataverse, rather than a different method. This issue should be helped by resolving this one: Optimize permission lookups for a user #6467. |
depends on completion of this issue: #6467 |
Link Dataverse and Link Datasert (both which show you DV collections) have different UI/UX. We should determine one that we end up using for both (once the backend permisisons work is compete): See #9092 |
To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'. If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment. |
The type ahead feature on the Linking popup is slow to respond to user input. Also, if a user types quickly, not all results that include what has been typed in are shown. This is problematic because it looks like not all results are returned.
All items that include "Tania Schlatter Dataverse":
What is shown when I type "Tania Schlatter Dataverse". "Tania Schlatter Dataverse" is not shown:
The typeahead for super users is more responsive and accurate:
The text was updated successfully, but these errors were encountered: