review: fix: Refactor code to fix runtime exception caused by package name with CtType.INNERTTYPE_SEPARATOR

src/main/java/spoon/reflect/factory/PackageFactory.java

@@ -16,7 +16,6 @@
 import spoon.reflect.declaration.CtModule;
 import spoon.reflect.declaration.CtPackage;
 import spoon.reflect.declaration.CtPackageDeclaration;
-import spoon.reflect.declaration.CtType;
 import spoon.reflect.reference.CtPackageReference;
 
 
@@ -155,9 +154,6 @@ public CtPackage getOrCreate(String qualifiedName, CtModule rootModule) {
 	 * @return a found package or null
 	 */
 	public CtPackage get(String qualifiedName) {
-		if (qualifiedName.contains(CtType.INNERTTYPE_SEPARATOR)) {
-			throw new RuntimeException("Invalid package name " + qualifiedName);
-		}
 
 		// Find package with the most contained types. If a module exports package "foo.bar" and the
 		// other "foo.bar.baz", *both modules* will contain a "foo.bar" package in spoon. As

src/test/java/spoon/reflect/factory/PackageFactoryTest.java

@@ -3,8 +3,10 @@
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.hamcrest.CoreMatchers.sameInstance;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.*;
 import org.junit.jupiter.api.Test;
 import spoon.Launcher;
+import spoon.reflect.declaration.CtClass;
 import spoon.reflect.declaration.CtPackage;
 import spoon.testing.utils.GitHubIssue;
 
@@ -29,4 +31,20 @@ void getOrCreate_returnsNestedPackageStructure_whenQualifiedNameRepeatsSimpleNam
 		assertThat(topLevelPackage.getPackage(topLevelPackageName), sameInstance(packageWithDuplicatedSimpleNames));
 		assertThat(packageWithDuplicatedSimpleNames.getParent(), sameInstance(topLevelPackage));
 	}
+
+	@Test
+	@GitHubIssue(issueNumber = 5140, fixed = true)
+	void testGetPackageWithNameContainingDollarSign() {
+		// contract: A package with a name containing a dollar sign can be retrieved using the PackageFactory
+		// Create a package with a name containing a dollar sign
+		String packageName = "com.example.package$with$dollar$sign";
+		CtClass<?> clazz = Launcher.parseClass("package " + packageName + ";" + "\n" + "enum Foo { }");
+
+		// Get the package using the PackageFactory
+		CtPackage ctPackage = clazz.getFactory().Package().get(packageName);
+
+		// Verify that the package was found
+		assertNotNull(ctPackage);
+		assertEquals(packageName, ctPackage.getQualifiedName());
+	}
 }