review: fix: Refactor code to fix runtime exception caused by package name with CtType.INNERTTYPE_SEPARATOR #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Type.INNERTTYPE_SEPARATOR. The check for the CtType.INNERTTYPE_SEPARATOR that caused runtime exceptions has been removed so that valid packages with CtType.INNERTTYPE_SEPARATOR can be found. A new test has been added to verify that a package with a name containing a dollar sign can be successfully retrieved using the PackageFactory.
MartinWitt
changed the title
MartinWitt
changed the title
I-Al-Istannen
requested changes
May 30, 2023
I-Al-Istannen
approved these changes
Jun 10, 2023
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check is 17 years old and $ is allowed in packages. Interesting that we had no bug reports earlier.
The check for the
CtType.INNERTTYPE_SEPARATORthat caused runtime exceptions has been removed so that valid packages withCtType.INNERTTYPE_SEPARATORcan be found.A new test has been added to verify that a package with a name containing a dollar sign can be successfully retrieved using the
PackageFactory.Fixes #5140