review: replace string literals by constants

src/main/java/spoon/reflect/reference/CtExecutableReference.java

@@ -33,6 +33,8 @@ public interface CtExecutableReference<T> extends CtReference, CtActualTypeConta
 
 	String CONSTRUCTOR_NAME = "<init>";
 
+	String LAMBDA_NAME_PREFIX = "lambda$";
+
 	String UNKNOWN_TYPE = "<unknown>";
 
 	/**

src/main/java/spoon/reflect/visitor/JavaIdentifiers.java

@@ -21,6 +21,8 @@
 import java.util.Set;
 import java.util.StringTokenizer;
 
+import spoon.reflect.reference.CtExecutableReference;
+
 /**
  * This enum defines the Java keywords and some helper method to determine if
  * some strings are Java identifiers.
@@ -99,7 +101,7 @@ public static boolean isLegalJavaExecutableIdentifier(String string) {
 		if (string == null) {
 			return false;
 		}
-		if (string.equals("<init>")) {
+		if (string.equals(CtExecutableReference.CONSTRUCTOR_NAME)) {
 			return true;
 		}
 		return isLegalJavaIdentifier(string);

src/main/java/spoon/support/reflect/code/CtStatementImpl.java

@@ -29,6 +29,7 @@
 import spoon.reflect.declaration.CtElement;
 import spoon.reflect.declaration.CtExecutable;
 import spoon.reflect.declaration.ParentNotInitializedException;
+import spoon.reflect.reference.CtExecutableReference;
 import spoon.reflect.visitor.CtInheritanceScanner;
 
 import java.util.ArrayList;
@@ -69,7 +70,7 @@ public static void insertBefore(CtStatement target, CtStatementList statementsTo
 		}
 		try {
 			if (target.getParent(CtConstructor.class) != null) {
-				if (target instanceof CtInvocation && ((CtInvocation<?>) target).getExecutable().getSimpleName().startsWith("<init>")) {
+				if (target instanceof CtInvocation && ((CtInvocation<?>) target).getExecutable().getSimpleName().startsWith(CtExecutableReference.CONSTRUCTOR_NAME)) {
 					throw new SpoonException("cannot insert a statement before a super or this invocation.");
 				}
 			}

src/main/java/spoon/support/reflect/declaration/CtConstructorImpl.java

@@ -25,6 +25,7 @@
 import spoon.reflect.declaration.CtTypeParameter;
 import spoon.reflect.declaration.CtTypedElement;
 import spoon.reflect.declaration.ModifierKind;
+import spoon.reflect.reference.CtExecutableReference;
 import spoon.reflect.reference.CtTypeParameterReference;
 import spoon.reflect.reference.CtTypeReference;
 import spoon.reflect.visitor.CtVisitor;
@@ -60,7 +61,7 @@ public <C extends CtNamedElement> C setSimpleName(String simpleName) {
 
 	@Override
 	public String getSimpleName() {
-		return "<init>";
+		return CtExecutableReference.CONSTRUCTOR_NAME;
 	}
 
 	@Override

src/main/java/spoon/support/reflect/eval/VisitorPartialEvaluator.java

@@ -49,6 +49,7 @@
 import spoon.reflect.declaration.CtVariable;
 import spoon.reflect.declaration.ModifierKind;
 import spoon.reflect.eval.PartialEvaluator;
+import spoon.reflect.reference.CtExecutableReference;
 import spoon.reflect.reference.CtFieldReference;
 import spoon.reflect.reference.CtTypeReference;
 import spoon.reflect.visitor.CtScanner;
@@ -380,7 +381,7 @@ public <T> void visitCtInvocation(CtInvocation<T> invocation) {
 			i.addArgument(re);
 		}
 		// do not partially evaluate super(...)
-		if (i.getExecutable().getSimpleName().equals("<init>")) {
+		if (i.getExecutable().getSimpleName().equals(CtExecutableReference.CONSTRUCTOR_NAME)) {
 			setResult(i);
 			return;
 		}

src/main/java/spoon/support/reflect/reference/CtExecutableReferenceImpl.java

@@ -158,13 +158,13 @@ private CtExecutable<T> getCtExecutable(CtType<?> typeDecl) {
 			return null;
 		}
 		CtExecutable<T> method = typeDecl.getMethod(getSimpleName(), parameters.toArray(new CtTypeReferenceImpl<?>[parameters.size()]));
-		if ((method == null) && (typeDecl instanceof CtClass) && (getSimpleName().equals("<init>"))) {
+		if ((method == null) && (typeDecl instanceof CtClass) && (getSimpleName().equals(CtExecutableReference.CONSTRUCTOR_NAME))) {
 			try {
 				return (CtExecutable<T>) ((CtClass<?>) typeDecl).getConstructor(parameters.toArray(new CtTypeReferenceImpl<?>[parameters.size()]));
 			} catch (ClassCastException e) {
 				Launcher.LOGGER.error(e.getMessage(), e);
 			}
-		} else if (method == null && getSimpleName().startsWith("lambda$")) {
+		} else if (method == null && getSimpleName().startsWith(CtExecutableReference.LAMBDA_NAME_PREFIX)) {
 			final List<CtLambda<T>> elements = (List<CtLambda<T>>) typeDecl.getElements(new NameFilter<CtLambda<T>>(getSimpleName()));
 			if (elements.size() == 0) {
 				return null;