Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: replace string literals by constants #1316

Merged
merged 1 commit into from
May 21, 2017

Conversation

pvojtechovsky
Copy link
Collaborator

replaces all "" by CtExecutableReference.CONSTRUCTOR_NAME.
replaces all "lambda$" by CtExecutableReference.LAMBDA_NAME_PREFIX.

@pvojtechovsky pvojtechovsky changed the title replace string literals by constants review: replace string literals by constants May 20, 2017
@pvojtechovsky
Copy link
Collaborator Author

May be the constants are not on good place.
CtConstructor.CONSTRUCTOR_NAME
CtLambda.LAMBDA_NAME_PREFIX
might be better... We must of course keep legacy CtExecutableReference constant too.
WDYT?

The reason for this PR is that I need lambda name prefix constant in new spoon code.

@monperrus monperrus merged commit d0d3f65 into INRIA:master May 21, 2017
@pvojtechovsky pvojtechovsky deleted the refStringLiterals branch May 21, 2017 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants