-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage QA fixes #83
Conversation
text-transform: uppercase; | ||
text-decoration: none; | ||
box-shadow: 0px 0px 24px @box-shadow-black; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed in 974bdf1. Good catch 😅
#legend { | ||
font-size: 16px; | ||
line-height: 16px; | ||
font-family: @font-map-labels; | ||
color: #221F1F; | ||
border: 2px solid #d1d2d3; | ||
padding: 0.5em; | ||
width: fit-content; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fit-content
isn't widely supported at this time: https://caniuse.com/#search=fit-content
max-content
works here, I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 538da70
} | ||
|
||
.ipbs-member-map-widget { | ||
margin-bottom: 0!important; | ||
#legend { | ||
font-size: 16px; | ||
line-height: 16px; | ||
font-family: @font-map-labels; | ||
color: #221F1F; | ||
border: 2px solid #d1d2d3; | ||
padding: 0.5em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this padding is superfluous as it's overwritten later in this same style block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in 538da70
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only big blocker now that button styles are fixed is fit-content
.
Changes
This pull request makes the following changes:
Reduces whitespace on the desktop and mobile header
Reduces height of featured image
Centers member station descriptive text
Adds map legend
Reduces top and bottom spacing on map
Decreases spacing on member stations list
Adds spacing above/below video widget
Adds "More Events" button styling
Widens sponsors slider
Reduces size of footer member station links
Why
For #35
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
Steps to test this PR:
Desktop and mobile header
Homepage featured area background image
Member map
More Events button for calendar
Video embed
Sponsors slider
Footer member station links