Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage QA fixes #83

Merged
merged 10 commits into from
Feb 6, 2020
Merged

Homepage QA fixes #83

merged 10 commits into from
Feb 6, 2020

Conversation

joshdarby
Copy link

@joshdarby joshdarby commented Feb 5, 2020

Changes

This pull request makes the following changes:

  • Reduces whitespace on the desktop and mobile header
    Screen Shot 2020-02-05 at 1 37 18 PM

  • Reduces height of featured image
    Screen Shot 2020-02-05 at 1 37 42 PM

  • Centers member station descriptive text

  • Adds map legend

  • Reduces top and bottom spacing on map
    Screen Shot 2020-02-05 at 1 38 53 PM

  • Decreases spacing on member stations list
    Screen Shot 2020-02-05 at 1 39 25 PM

  • Adds spacing above/below video widget
    Screen Shot 2020-02-05 at 1 39 57 PM

  • Adds "More Events" button styling
    Screen Shot 2020-02-05 at 1 40 23 PM

  • Widens sponsors slider
    Screen Shot 2020-02-05 at 1 40 50 PM

  • Reduces size of footer member station links
    Screen Shot 2020-02-05 at 1 41 13 PM

Why

For #35

Testing/Questions

Features that this PR affects:

  • Site header
  • Homepage featured area background image
  • Member map widget
  • Member stations widget
  • Video embed widget area
  • Sponsors slider
  • Footer area lists
  • Buttons

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?

Steps to test this PR:

Desktop and mobile header

  1. View the frontend and verify the new reduced spacing looks ok

Homepage featured area background image

  1. View the frontend and verify the reduced background image size still looks ok

Member map

  1. View the widget and verify the legend displays now
  2. Make sure the new map size looks ok

More Events button for calendar

  1. Add a custom HTML widget under the calendar widget and paste this
<div style="text-align:center;">
	<a href="#" class="btn btn-blue">More Events</a>
</div>
  1. View on the frontend and verify it looks ok

Video embed

  1. Make sure new spacing looks ok

Sponsors slider

  1. View the slider and make sure the slider is wider than it previously was

Footer member station links

  1. View the footer menu station links and make sure the new font size looks ok

@joshdarby joshdarby added this to the Homepage milestone Feb 5, 2020
@joshdarby joshdarby self-assigned this Feb 5, 2020
text-transform: uppercase;
text-decoration: none;
box-shadow: 0px 0px 24px @box-shadow-black;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-02-05 at 16 39 11

The .btn styles apply to the button in the mobile nav. 😢

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed in 974bdf1. Good catch 😅

#legend {
font-size: 16px;
line-height: 16px;
font-family: @font-map-labels;
color: #221F1F;
border: 2px solid #d1d2d3;
padding: 0.5em;
width: fit-content;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fit-content isn't widely supported at this time: https://caniuse.com/#search=fit-content

max-content works here, I think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 538da70

}

.ipbs-member-map-widget {
margin-bottom: 0!important;
#legend {
font-size: 16px;
line-height: 16px;
font-family: @font-map-labels;
color: #221F1F;
border: 2px solid #d1d2d3;
padding: 0.5em;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this padding is superfluous as it's overwritten later in this same style block.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 538da70

Copy link
Collaborator

@benlk benlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only big blocker now that button styles are fixed is fit-content.

@benlk benlk mentioned this pull request Feb 5, 2020
3 tasks
@joshdarby joshdarby requested a review from benlk February 6, 2020 14:58
@benlk benlk merged commit 3e0f1de into master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants