Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing, QA, & Fixes #35

Open
MirandaEcho opened this issue Jan 6, 2020 · 14 comments
Open

Testing, QA, & Fixes #35

MirandaEcho opened this issue Jan 6, 2020 · 14 comments

Comments

@MirandaEcho
Copy link
Collaborator

No description provided.

@MirandaEcho MirandaEcho added this to the Testing & QA milestone Jan 6, 2020
@MirandaEcho
Copy link
Collaborator Author

MirandaEcho commented Feb 5, 2020

Homepage Desktop

  • Double check fonts - headers look wrong
  • Reduce white space and tighten up site header, especially above and below logo as much as possible
  • Reduce the height of the featured image (crop placeholder if needed, client had concern about scroll depth for the top area)
  • Can the member station descriptive text be centered and constrained like the mockup?
  • Reduce size of member map on desktop
  • Member station map key is missing (it wasn't in the desktop mockup, apparently, but was in mobile and is on the live site)
  • Reduce white space above and below member map embed
  • Decrease height (and overall size) of member list sections
  • Features section is broken - do we need to add content here to QA?
  • Add some space above and below video embed section
  • More events button missing
  • Can sponsors slider be wider?
  • Footer: Text color is white instead of very light gray
  • Footer: Can we reduce the font size for the member station links by a few px?

@MirandaEcho
Copy link
Collaborator Author

MirandaEcho commented Feb 5, 2020

Homepage Mobile

  • Mobile Header: Reduce white space above and below logo
  • Featured image is a bit too small (height) - see mockup
  • Reduce white space above member stations

@benlk
Copy link
Collaborator

benlk commented Feb 5, 2020

On fonts: Should we use the thin fonts from the early PDFs, which were screenshotted for many of the issues here, or the thick fonts from the Adobe XD designs, which were what got put on the site?

@MirandaEcho
Copy link
Collaborator Author

MirandaEcho commented Feb 5, 2020

Interior Page Template (desktop):

Note: Test Page to match mockup features: http://ipbs.staging.wpengine.com/?page_id=530

  • remove byline & date from template

  • Left align blocks overlay if placed too close together:
    Screen Shot 2020-02-04 at 7 53 44 PM

  • Needs to be more space between blocks on left and text on right

  • Missing spacer line in article prefooter between body text and sponsors section
    Screen Shot 2020-02-04 at 7 56 27 PM

  • Update URL slug rules to use page title to create slug, rather than just Page ID

@MirandaEcho
Copy link
Collaborator Author

Interior page: Mobile

  • Mobile menu displays over page title

@joshdarby
Copy link

Features section is broken - do we need to add content here to QA?

Yes, this is a Largo Recent Posts widget. There are 0 published posts on the site, which is why nothing appears in that widget.

@joshdarby
Copy link

joshdarby commented Feb 5, 2020

Double check fonts - headers look wrong

The design uses Inter, Extra Bold.

h1-6 and .widgettitle use 'Inter',... with font-weight: 800; as specified by the Inter font repo guide

Screen Shot 2020-02-05 at 9 39 46 AM

@joshdarby
Copy link

Footer: Text color is white instead of very light gray

The designs show the footer text color as #FFF

Screen Shot 2020-02-05 at 10 00 45 AM

@joshdarby
Copy link

Video is cropped horizontally on mobile

@MirandaEcho Do you have an example of this?

@benlk
Copy link
Collaborator

benlk commented Feb 5, 2020

I'm seeing letterboxing, but that's kind of expected? Unless there's an aspect ratio class we can use to make it keep the right shape.

Screen Shot 2020-02-05 at 12 35 34
Screen Shot 2020-02-05 at 12 35 23

@joshdarby
Copy link

I'm seeing letterboxing, but that's kind of expected?

That's what I'm seeing too.

@joshdarby
Copy link

Featured image is a bit too small (height) - see mockup

In the design its height is 170px. On the actual site it's 315px.

@benlk
Copy link
Collaborator

benlk commented Feb 5, 2020

Update URL slug rules to use page title to create slug, rather than just Page ID

I've updated the permalink structure on staging to /%year%/%monthnum%/%day%/%postname%/, which has the effect of making the page permalink structure be /%postname%/

@joshdarby joshdarby mentioned this issue Feb 5, 2020
1 task
@benlk benlk mentioned this issue Feb 5, 2020
3 tasks
@benlk
Copy link
Collaborator

benlk commented Feb 5, 2020

The interior page revisions in #84 came in at just over an hour, before review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants