Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing error for 0-dimensional HDF5 datasets #1206

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 21, 2023

@dweindl dweindl requested review from PaulJonasJost and a team as code owners November 21, 2023 08:46
* Refactor ProfileResultHDF5Writer to be more readable
* Raise more informative error if writing to HDF5 fails
* Don't index 0-dimensional datasets (Fixes ICB-DCM#1205)
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a6e300f) 81.40% compared to head (a20c703) 81.38%.
Report is 1 commits behind head on develop.

Files Patch % Lines
pypesto/store/save_to_hdf5.py 87.50% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1206      +/-   ##
===========================================
- Coverage    81.40%   81.38%   -0.02%     
===========================================
  Files          148      148              
  Lines        11785    11794       +9     
===========================================
+ Hits          9593     9598       +5     
- Misses        2192     2196       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we perhaps need more extensive testing on the histories?

@dweindl
Copy link
Member Author

dweindl commented Nov 21, 2023

Do we perhaps need more extensive testing on the histories?

Wouldn't hurt. But if we'd just fix issues instead of re-running tests we should be fine :)

@dweindl dweindl merged commit bdabe8d into ICB-DCM:develop Nov 21, 2023
17 checks passed
@dweindl dweindl deleted the fix_1205 branch November 21, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store.write_result: ValueError: 1 indexing arguments for 0 dimensions
3 participants