Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1199: Add drag and drop functionality on DM tabs #6079

Merged
merged 15 commits into from
Jul 24, 2024

Conversation

juliosgarbi
Copy link
Contributor

@juliosgarbi juliosgarbi commented Jul 10, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Currently, users cannot move tabs around, which is inconvenient. They must delete ("Close") tabs and recreate them in the desired order. This update allows users to reorder tabs by dragging and dropping them.

Key features:

  • Drag and drop functionality for tabs.
  • Visual indicator to show the drop location.
  • Dragging not confined to vertical tab limits.
  • Tabs can be reordered regardless of visibility.
  • Order of tabs is consistent across the organization after a hard refresh.
  • No disruption for concurrent users.
  • ESC key cancels the drag action, returning the tab to its original position.

Screen-Recording-2024-07-16-at-18 09 18

@github-actions github-actions bot added the feat label Jul 10, 2024
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit fc91b05
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/669fcc7550a926000830f879
😎 Deploy Preview https://deploy-preview-6079--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit fc91b05
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/669fcc75d9b7cc0008c8b6f7
😎 Deploy Preview https://deploy-preview-6079--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@triklozoid
Copy link
Contributor

triklozoid commented Jul 16, 2024

/git merge develop

Workflow run
Successfully merged: rename web/dist/apps/labelstudio/{book.d787a03585e3dfbb093186a4f7e882d3.svg => book.23db5e3751679a820c6e975e99f29323.svg} (70%)

triklozoid and others added 2 commits July 16, 2024 12:49
* feat: LEAP-1241: Views ordering

* Fix urls test

* Add index for project+order field

---------

Co-authored-by: triklozoid <[email protected]>
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.76%. Comparing base (1a69603) to head (fc91b05).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6079      +/-   ##
===========================================
+ Coverage    76.73%   76.76%   +0.03%     
===========================================
  Files          168      168              
  Lines        13628    13650      +22     
===========================================
+ Hits         10458    10479      +21     
- Misses        3170     3171       +1     
Flag Coverage Δ
pytests 76.76% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmartel and others added 3 commits July 16, 2024 11:24
@juliosgarbi
Copy link
Contributor Author

juliosgarbi commented Jul 16, 2024

/git merge develop

Workflow run
Successfully merged: Already up to date.

Copy link
Contributor

@jombooth jombooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to rework the migration that's included in this PR to make the new field nullable; code depending on the new field should handle nulls.

@juliosgarbi
Copy link
Contributor Author

juliosgarbi commented Jul 23, 2024

/git merge develop

Workflow run
Successfully merged: 29 files changed, 302 insertions(+), 96 deletions(-)

@juliosgarbi juliosgarbi merged commit ab1fe0a into develop Jul 24, 2024
40 checks passed
@juliosgarbi juliosgarbi deleted the fb-leap-1199 branch July 24, 2024 13:44
@RiccardoMaistri
Copy link

Good morning!
Does the drag and drop funcitonality has to be enabled or enteprse version is required? I am running Label studio v 1.13.1 deployed using helm chart. I am using Version 130.0.6723.91 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants