fix: OPTIC-885: Links not clickable from within Radio Button #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
yyassi-heartex
approved these changes
Jul 15, 2024
wesleylima
approved these changes
Jul 15, 2024
hlomzik
approved these changes
Jul 15, 2024
AndrejOros
approved these changes
Jul 16, 2024
bmartel
added a commit
that referenced
this pull request
Jul 16, 2024
* fix: OPTIC-885: Links not clickable from within Radio Button * add a comment stating this fix needs to be revisited
bmartel
added a commit
that referenced
this pull request
Jul 16, 2024
juliosgarbi
pushed a commit
that referenced
this pull request
Jul 16, 2024
* fix: OPTIC-885: Links not clickable from within Radio Button * add a comment stating this fix needs to be revisited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
The Radio Component allows an extended description to be provided as a label to the element, and when this option is utilized with links embedded in the description JSX the clickHandler would stop propagation of this event from the anchor tag which never allows for the links to be clickable. If the element which sourced the bubbled event is an anchor tag, leave the event alone to retain normal web behaviour and skip the Radio Component clickHandler.