fix: Add missing storage title field to Redis config #5552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a required missing field to the Redis storage form -- the storage title. Without this field, the UI will throw an exception when trying to display the saved configuration's card. See [Slack](https://label-studio.slack.com/archives/CQ8LYQ0J2/p1709796798556099) for details.
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
makseq
approved these changes
Mar 26, 2024
|
/jira create
|
sajarin
added
Community
jombooth
added a commit
that referenced
this pull request
Jun 14, 2024
[Re-created using `gh` command line tool for CI (mirror #5552] This commit adds a required missing field to the Redis storage form -- the storage title. Without this field, the UI will throw an exception when trying to display the saved configuration's card. See [Slack](https://label-studio.slack.com/archives/CQ8LYQ0J2/p1709796798556099) for details. Also fix the port showing up as `undefined` on the frontend's storage card. We'll need to make a similar change in LSE. --------- Co-authored-by: Justin Ziniel <[email protected]> Co-authored-by: jombooth <[email protected]> Co-authored-by: robot-ci-heartex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a required missing field to the Redis storage form -- the storage title. Without this field, the UI will throw an exception when trying to display the saved configuration's card. See Slack for details.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
See this Slack thread for a description of the problem.
What does this fix?
This fixes an issue with creating Redis storage configurations in the UI, namely that the storage title is missing from the form. Without it, the UI raises an exception when trying to display a
nulltitle on the configuration card.What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)