-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: TRIAG-600: Add missing storage title field to Redis config (#5985)
[Re-created using `gh` command line tool for CI (mirror #5552] This commit adds a required missing field to the Redis storage form -- the storage title. Without this field, the UI will throw an exception when trying to display the saved configuration's card. See [Slack](https://label-studio.slack.com/archives/CQ8LYQ0J2/p1709796798556099) for details. Also fix the port showing up as `undefined` on the frontend's storage card. We'll need to make a similar change in LSE. --------- Co-authored-by: Justin Ziniel <[email protected]> Co-authored-by: jombooth <[email protected]> Co-authored-by: robot-ci-heartex <[email protected]>
- Loading branch information
1 parent
3ebe34a
commit 590c8a4
Showing
8 changed files
with
26 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ jobs: | |
main: | ||
name: "yarn e2e" | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 45 | ||
timeout-minutes: 60 | ||
steps: | ||
- uses: hmarr/[email protected] | ||
|
||
|
@@ -56,11 +56,11 @@ jobs: | |
BUILD_NO_MINIMIZATION: true | ||
run: | | ||
set -xeuo pipefail | ||
yarn lsf:serve & | ||
pid=$! | ||
echo "pid=${pid}" >> $GITHUB_OUTPUT | ||
while ! curl -s -o /dev/null -L "http://localhost:3000"; do | ||
echo "=> Waiting for service to become available" | ||
sleep 2s | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "feat: LEAP-1020: Relation side panel improvements (#5711)", | ||
"commit": "9df4eb93ccd4a94a587375f50a225bd754d0df1d", | ||
"date": "2024-06-14T14:28:49.000Z", | ||
"branch": "develop" | ||
"message": "Merge branch 'develop' into 'fb-TRIAG-600/redis-fields'", | ||
"commit": "32748f4b980fdcad979a60e29ccd4cf0cb6b2dc7", | ||
"date": "2024-06-14T13:56:23.000Z", | ||
"branch": "fb-TRIAG-600/redis-fields" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "feat: LEAP-1020: Relation side panel improvements (#5711)", | ||
"commit": "9df4eb93ccd4a94a587375f50a225bd754d0df1d", | ||
"date": "2024-06-14T14:28:49.000Z", | ||
"branch": "develop" | ||
"message": "Merge branch 'develop' into 'fb-TRIAG-600/redis-fields'", | ||
"commit": "32748f4b980fdcad979a60e29ccd4cf0cb6b2dc7", | ||
"date": "2024-06-14T13:56:23.000Z", | ||
"branch": "fb-TRIAG-600/redis-fields" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "feat: LEAP-1020: Relation side panel improvements (#5711)", | ||
"commit": "9df4eb93ccd4a94a587375f50a225bd754d0df1d", | ||
"date": "2024-06-14T14:28:49.000Z", | ||
"branch": "develop" | ||
"message": "Merge branch 'develop' into 'fb-TRIAG-600/redis-fields'", | ||
"commit": "32748f4b980fdcad979a60e29ccd4cf0cb6b2dc7", | ||
"date": "2024-06-14T13:56:23.000Z", | ||
"branch": "fb-TRIAG-600/redis-fields" | ||
} |