Add drs_uri to DCP/2 file descriptor
#1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoopDog
approved these changes
Sep 10, 2024
ncalvanese1
approved these changes
Sep 10, 2024
amnonkhen
approved these changes
Sep 20, 2024
ESapenaVentura
force-pushed
the
hs-file-descriptor-drs-uri
branch
from
3a52c1b to
7c41410
Compare
The immediate need is for LungMAP but this property could be useful in other contexts as it allows for files to be hosted by DRS implementations other than TDR.
ESapenaVentura
force-pushed
the
hs-file-descriptor-drs-uri
branch
from
7c41410 to
e1b29c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #1437
The immediate need is for LungMAP but this property could be useful in other contexts as it allows for files to be hosted by DRS implementations other than TDR.
I took Andrew's changes from that old PR, squashed them down into a single commit and removed what I believe to be cruft. The branch is based on staging.