Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCA schemas for descriptor lacks drs_uri property #6516

Open
nadove-ucsc opened this issue Aug 23, 2024 · 7 comments
Open

HCA schemas for descriptor lacks drs_uri property #6516

nadove-ucsc opened this issue Aug 23, 2024 · 7 comments
Assignees
Labels
- [priority] Medium data [subject] Data or metadata [use of this label is uncommon] orange [process] Done by the Azul team task [type] Resolution requires engineering action other than code changes

Comments

@nadove-ucsc
Copy link
Contributor

nadove-ucsc commented Aug 23, 2024

This property is only present in LungMap snapshots, which use a version of the schema from an un-merged feature branch.

https://raw.githubusercontent.com/HumanCellAtlas/metadata-schema/lungmap-phantom-files/json_schema/system/file_descriptor.json

@nadove-ucsc nadove-ucsc added orange [process] Done by the Azul team invalid [process] Can't be reproduce or works as specified and removed invalid [process] Can't be reproduce or works as specified labels Aug 23, 2024
@nadove-ucsc
Copy link
Contributor Author

Assignee to consider next steps.

@hannes-ucsc
Copy link
Member

I dusted off the old PR against the schema repo: HumanCellAtlas/metadata-schema#1575 and asked for EBI's help in finishing it.

@hannes-ucsc
Copy link
Member

I will continue tending to that new schema PR. Once it has been merged, we'll need to ask LungMAP to stop referring to the schema on the stale feature branch and instead point to the HCA schema repository. They'll likely need to update all of their current projects and TDR needs to re-import them.

@hannes-ucsc hannes-ucsc added task [type] Resolution requires engineering action other than code changes data [subject] Data or metadata [use of this label is uncommon] - [priority] Medium labels Sep 7, 2024
@hannes-ucsc hannes-ucsc removed their assignment Sep 7, 2024
@hannes-ucsc
Copy link
Member

Enrique from EBI helped with the PR and I requested review on it.

@hannes-ucsc
Copy link
Member

Schema PR has been merged and deployed.

@hannes-ucsc
Copy link
Member

hannes-ucsc commented Oct 22, 2024

Additionally, LungMAP states that they updated all schema references to use the deployed schema but we shouldn't trust their word on it.

Assignee to create PR that requires all HCA schema URLs to use netloc schema.humancellatlas.org.

We may have cans that refer to other schema locations but those should only be accepted during tests.

@hannes-ucsc hannes-ucsc removed their assignment Oct 22, 2024
@dsotirho-ucsc dsotirho-ucsc self-assigned this Oct 22, 2024
@dsotirho-ucsc
Copy link
Contributor

@hannes-ucsc: "Let's initially assume schema.humancellatlas.org is referenced by metadata JSON files, canned or live. Fix any test failures, then file a PR."

dsotirho-ucsc added a commit that referenced this issue Dec 19, 2024
dsotirho-ucsc added a commit that referenced this issue Dec 19, 2024
dsotirho-ucsc added a commit that referenced this issue Dec 21, 2024
dsotirho-ucsc added a commit that referenced this issue Jan 9, 2025
dsotirho-ucsc added a commit that referenced this issue Jan 10, 2025
dsotirho-ucsc added a commit that referenced this issue Jan 13, 2025
dsotirho-ucsc added a commit that referenced this issue Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- [priority] Medium data [subject] Data or metadata [use of this label is uncommon] orange [process] Done by the Azul team task [type] Resolution requires engineering action other than code changes
Projects
None yet
Development

No branches or pull requests

3 participants