-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add default account overrides with .hsaccount
file
#228
Open
kemmerle
wants to merge
7
commits into
main
Choose a base branch
from
add/defaultaccountoverrides1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+88
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
January 17, 2025 16:58
kemmerle
commented
Jan 17, 2025
kemmerle
changed the title
Feature (POC): Add default account overrides with
Feature: Add default account overrides with Jan 17, 2025
.hs-account
file.hs-account
file
The code in here seems reasonable to me! I'll test this out early next week 🎉 |
joe-yeager
reviewed
Jan 21, 2025
2 tasks
joe-yeager
reviewed
Jan 23, 2025
joe-yeager
approved these changes
Jan 23, 2025
Just one suggestion to add another try/catch, but otherwise this all lgtm! |
kemmerle
changed the title
Feature: Add default account overrides with
Feature: Add default account overrides with Jan 24, 2025
.hs-account
file.hsaccount
file
joe-yeager
reviewed
Jan 29, 2025
joe-yeager
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
In this PR, I've implemented support for default account overrides with the new centralized configuration file.
Now, customers can place a
.hs-account
file in any directory where they would like the default account overridden. The.hs-account
file will contain a single numerical entry:1234567
, or the account ID. Any changes made in the directory and its subdirectories will apply in the account stipulated in the.hs-account
file. This will work very similarly to our nest configs currently do.The advantages are:
.hs-account
file, so that customers need never have to manually interact with the config.TODO
Who to Notify
@brandenrodgers @camden11 @joe-yeager