Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add default account overrides with .hsaccount file #228

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kemmerle
Copy link
Contributor

Description and Context

In this PR, I've implemented support for default account overrides with the new centralized configuration file.

Now, customers can place a .hs-account file in any directory where they would like the default account overridden. The .hs-account file will contain a single numerical entry: 1234567, or the account ID. Any changes made in the directory and its subdirectories will apply in the account stipulated in the .hs-account file. This will work very similarly to our nest configs currently do.

The advantages are:

  1. We will still have one centralized configuration file and therefore one single source of truth.
  2. We will create a command to auto-generate the .hs-account file, so that customers need never have to manually interact with the config.
  3. It's much more secure, if a customer accidentally uploads the file to GitHub--it contains no sensitive information besides an account ID.

TODO

  • Address feedback

Who to Notify

@brandenrodgers @camden11 @joe-yeager

lang/en.json Outdated Show resolved Hide resolved
@kemmerle kemmerle changed the title Feature (POC): Add default account overrides with .hs-account file Feature: Add default account overrides with .hs-account file Jan 17, 2025
@brandenrodgers
Copy link
Contributor

The code in here seems reasonable to me! I'll test this out early next week 🎉

config/CLIConfiguration.ts Outdated Show resolved Hide resolved
config/CLIConfiguration.ts Outdated Show resolved Hide resolved
@joe-yeager joe-yeager self-requested a review January 23, 2025 19:44
@brandenrodgers
Copy link
Contributor

Just one suggestion to add another try/catch, but otherwise this all lgtm!

@kemmerle kemmerle changed the title Feature: Add default account overrides with .hs-account file Feature: Add default account overrides with .hsaccount file Jan 24, 2025
config/CLIConfiguration.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants