Feature: Add support for default account override #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
changed the title
kemmerle
changed the title
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
kemmerle
changed the title
brandenrodgers
previously approved these changes
Feb 6, 2025
joe-yeager
approved these changes
Feb 6, 2025
Comment on lines
+127
to
+142
| if (this.diagnosticInfo?.defaultAccountOverrideFile) { | ||
| this.diagnosis?.addDefaultAccountOverrideFileSection({ | ||
| type: 'warning', | ||
| message: i18n(`${localI18nKey}.overrideActive`, { | ||
| defaultAccountOverrideFile: | ||
| this.diagnosticInfo.defaultAccountOverrideFile, | ||
| }), | ||
| }); | ||
| this.diagnosis?.addDefaultAccountOverrideFileSection({ | ||
| type: 'warning', | ||
| message: i18n(`${localI18nKey}.overrideAccountId`, { | ||
| overrideAccountId: getCWDAccountOverride(), | ||
| }), | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we want to do any checks on the validity of the account? Should these be warnings by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Relies on HubSpot/hubspot-local-dev-lib#228
In this PR, I'm implementing support for default account overrides with the new centralized configuration file.
Now, customers can place a
.hs-accountfile in any directory where they would like the default account overridden. The.hs-accountfile will contain a single numerical entry:1234567, or the account ID. Any changes made in the directory and its subdirectories will apply in the account stipulated in the.hs-accountfile. This will work very similarly to our nest configs currently do.The advantages are:
.hs-accountfile, so that customers need never have to manually interact with the config.TODO
hs accounts create-overridecommandWho to Notify
@brandenrodgers @camden11 @joe-yeager