Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Update node stable to v0.10.22 #24231

Closed
wants to merge 1 commit into from
Closed

Update node stable to v0.10.22 #24231

wants to merge 1 commit into from

Conversation

bbhoss
Copy link
Contributor

@bbhoss bbhoss commented Nov 12, 2013

Also updated the xcode_emulation patch to gyp. It appears that there
were some minor changes that just needed fixing up.

Redid the patch, unlike #24230

@mistydemeo
Copy link
Member

Is there anything in xcode-emulation that tries to call xcodebuild still?

@bbhoss
Copy link
Contributor Author

bbhoss commented Nov 12, 2013

Yeah, but it looks like they moved the actual Popen to _GetStdout, which now uses subprocess.PIPE only, like the previous patch does.

  def _GetStdout(self, cmdlist):
    job = subprocess.Popen(cmdlist, stdout=subprocess.PIPE)
    out = job.communicate()[0]
    if job.returncode != 0:
      sys.stderr.write(out + '\n')
      raise GypError('Error %d running %s' % (job.returncode, cmdlist[0]))
    return out.rstrip('\n')

  def _GetSdkVersionInfoItem(self, sdk, infoitem):
    return self._GetStdout(['xcodebuild', '-version', '-sdk', sdk, infoitem])

@bbhoss
Copy link
Contributor Author

bbhoss commented Nov 12, 2013

Not sure what to do about the failing --devel application. Looks like they haven't released a dev version with the changes to xcode_emulation yet. Ideas?

@mistydemeo
Copy link
Member

The patches method could return different results depending on if build.devel? or build.stable?

@bbhoss
Copy link
Contributor Author

bbhoss commented Nov 12, 2013

I'll fix that now.

@bbhoss
Copy link
Contributor Author

bbhoss commented Nov 12, 2013

Fixed. Both seem to compile locally for me on Mavericks

@mistydemeo
Copy link
Member

Thanks! Let's see if it works on the bots.

(Minor nitpick: our commit message format for version bumps is formula version, e.g. node 0.10.22)

# Latest versions of NodeJS stable have changed gyp's xcode_emulation, so
# it requires a different patch than devel currently. This will probably go away soon
if build.stable?
['https://gist.github.com/bbhoss/7439859/raw/9037240e90c62ce462383469874d4c269e3ead0d/xcode_emulation.patch']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patches can return a single URL string if there's only one patch.

Updated the xcode_emulation patch to gyp. It appears that there
were some minor changes that just needed fixing up. Devel and
HEAD still require the old patch, but that will probably change
pretty soon.
@bbhoss
Copy link
Contributor Author

bbhoss commented Nov 12, 2013

Fixed those minor qualms. It seems that the test runner/builder doesn't like my force pushes possibly? Looks like the status is missing. I can re-send if need be.

@mistydemeo
Copy link
Member

The bots take a few minutes to pick up on the updates when you force-push. They're building now.

@mistydemeo
Copy link
Member

Looks like all is well!

@chrmoritz
Copy link
Contributor

Does the new patch apply to 0.11.8 as devel?

@bbhoss
Copy link
Contributor Author

bbhoss commented Nov 13, 2013

There are two patches, one for v0.10.22 (which appears to be the only release with these gyp changes), and an alternate (the old patch), for all other versions.

@adamv adamv mentioned this pull request Nov 13, 2013
@adamv adamv closed this in 96b89f7 Nov 13, 2013
yriveiro pushed a commit to yriveiro/homebrew that referenced this pull request Nov 26, 2013
Closes Homebrew#24231.

Signed-off-by: Adam Vandenberg <[email protected]>
ehershey pushed a commit to ehershey/homebrew that referenced this pull request Apr 4, 2014
Closes Homebrew#24231.

Signed-off-by: Adam Vandenberg <[email protected]>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants