-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Conversation
Is there anything in xcode-emulation that tries to call xcodebuild still? |
Yeah, but it looks like they moved the actual Popen to _GetStdout, which now uses subprocess.PIPE only, like the previous patch does. def _GetStdout(self, cmdlist):
job = subprocess.Popen(cmdlist, stdout=subprocess.PIPE)
out = job.communicate()[0]
if job.returncode != 0:
sys.stderr.write(out + '\n')
raise GypError('Error %d running %s' % (job.returncode, cmdlist[0]))
return out.rstrip('\n')
def _GetSdkVersionInfoItem(self, sdk, infoitem):
return self._GetStdout(['xcodebuild', '-version', '-sdk', sdk, infoitem]) |
Not sure what to do about the failing --devel application. Looks like they haven't released a dev version with the changes to xcode_emulation yet. Ideas? |
The |
I'll fix that now. |
Fixed. Both seem to compile locally for me on Mavericks |
Thanks! Let's see if it works on the bots. (Minor nitpick: our commit message format for version bumps is |
# Latest versions of NodeJS stable have changed gyp's xcode_emulation, so | ||
# it requires a different patch than devel currently. This will probably go away soon | ||
if build.stable? | ||
['https://gist.github.com/bbhoss/7439859/raw/9037240e90c62ce462383469874d4c269e3ead0d/xcode_emulation.patch'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patches
can return a single URL string if there's only one patch.
Updated the xcode_emulation patch to gyp. It appears that there were some minor changes that just needed fixing up. Devel and HEAD still require the old patch, but that will probably change pretty soon.
Fixed those minor qualms. It seems that the test runner/builder doesn't like my force pushes possibly? Looks like the status is missing. I can re-send if need be. |
The bots take a few minutes to pick up on the updates when you force-push. They're building now. |
Looks like all is well! |
Does the new patch apply to 0.11.8 as devel? |
There are two patches, one for v0.10.22 (which appears to be the only release with these gyp changes), and an alternate (the old patch), for all other versions. |
Closes Homebrew#24231. Signed-off-by: Adam Vandenberg <[email protected]>
Closes Homebrew#24231. Signed-off-by: Adam Vandenberg <[email protected]>
Also updated the xcode_emulation patch to gyp. It appears that there
were some minor changes that just needed fixing up.
Redid the patch, unlike #24230