Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

node 0.10.22 #24230

Closed
wants to merge 1 commit into from
Closed

node 0.10.22 #24230

wants to merge 1 commit into from

Conversation

andriichyzh
Copy link
Contributor

Update Node.js version

@mistydemeo
Copy link
Member

The patch is failing to apply.

@adamv
Copy link
Contributor

adamv commented Nov 12, 2013

Did this build for you locally?

@mistydemeo
Copy link
Member

Really hoping not too much changed in gyp, not looking forward to rewriting that patch.

@andriichyzh
Copy link
Contributor Author

Changed only link and a checksum. In what could be the problem?

@adamv
Copy link
Contributor

adamv commented Nov 12, 2013

Let me repeat my question: Did this build for you locally?

@adamv
Copy link
Contributor

adamv commented Nov 12, 2013

The patches are no longer applying, since this is a new version of Node, the source has changed, and has apparently changed in a way that the patches we carry are no longer valid.

@andriichyzh
Copy link
Contributor Author

Did this build for you locally?

Error on patching...

==> Upgrading 1 outdated package, with result:
node 0.10.22
==> Upgrading node
==> Downloading http://nodejs.org/dist/v0.10.22/node-v0.10.22.tar.gz
######################################################################## 100.0%
==> Patching
patching file tools/gyp/pylib/gyp/xcode_emulation.py
Hunk #1 FAILED at 224.
Hunk #2 FAILED at 233.
Hunk #3 succeeded at 404 (offset 58 lines).
Hunk #4 succeeded at 655 (offset 75 lines).
Hunk #5 FAILED at 784.
3 out of 5 hunks FAILED -- saving rejects to file tools/gyp/pylib/gyp/xcode_emulation.py.rej
Error: Failure while executing: /usr/bin/patch -f -p1 -i 000-homebrew.diff

@bbhoss
Copy link
Contributor

bbhoss commented Nov 12, 2013

Fixed the patch in mine, seems to work fine.

@adamv
Copy link
Contributor

adamv commented Nov 13, 2013

Closing in favor of #24231.

@adamv adamv closed this Nov 13, 2013
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants