Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtasn1 4.17.0 #77228

Closed
wants to merge 2 commits into from
Closed

libtasn1 4.17.0 #77228

wants to merge 2 commits into from

Conversation

JeffreyBytes
Copy link
Contributor

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label May 13, 2021
@cho-m
Copy link
Member

cho-m commented May 13, 2021

Need to update patch block.

Upstream issue is still open: https://gitlab.com/gnutls/libtasn1/-/issues/30
So, probably need to see if new patch is necessary on 4.17.0.

@JeffreyBytes
Copy link
Contributor Author

I see the upstream issue is still open, but when I remove the patch block the build and brew test succeed.
Do you think patch is no longer necessary?

I was reading over the patch block in the formula cookbook, and don't completely understand what it is doing.

@carlocab
Copy link
Member

carlocab commented May 13, 2021 •
edited
Loading

The patch isn't for a build failure, but to fix an issue with UB. I think we need a different patch.

The fix seems to have been merged here, I think? https://gitlab.com/gnutls/libtasn1/-/merge_requests/74

Not sure why the issue is still open, though. If it hasn't been resolved then we probably still need a different patch.

@cho-m
Copy link
Member

cho-m commented May 13, 2021

It looks like they may have just forgot to close the issue.

I think it is fine to simply remove patch block in this case.

@carlocab
Copy link
Member

Asked for clarification at https://gitlab.com/gnutls/libtasn1/-/issues/30. Let's wait for a response there before dropping the patch.

@roolebo
Copy link
Contributor

roolebo commented May 13, 2021

@cho-m, @carlocab yeah, it should be ok to drop the patch. Thanks!

@carlocab
Copy link
Member

Thanks, @roolebo.

@carlocab
Copy link
Member

carlocab commented May 14, 2021 •
edited
Loading

On ARM:

Error: 1 failed step!
brew test --retry --verbose monkeysphere

We can fix this by bumping the revision now that Perl shebang handling has been merged. #77242

@carlocab carlocab mentioned this pull request May 14, 2021
Closed
5 tasks
carlocab added a commit to carlocab/homebrew-core that referenced this pull request May 14, 2021
@carlocab
monkeysphere: revision bump (perl shebang fix)
def2455 
Fixes CI failure seen in Homebrew#77228 and various other PRs. Also, update the
license, and use `https` in homepage.

See Homebrew/brew#11286.

License ref:

    https://metadata.ftp-master.debian.org/changelogs//main/m/monkeysphere/monkeysphere_0.44-1_copyright
@carlocab
Copy link
Member

Thanks, @spaz926.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@JeffreyBytes JeffreyBytes deleted the bump-libtasn1-4.17.0 branch May 14, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeffreyBytes @cho-m @carlocab @roolebo @BrewTestBot