Use versioned Perl shebangs on macOS and support replacing shebangs during relocation #11286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2021-04-30 at 16:56:45 UTC. |
BrewTestBot
added
the
waiting for feedback
Bo98
commented
Apr 29, 2021
|
Due to the nature of changing relocation, there is a window between this potentially being merged and a new brew tag being released where bottles will be created in our CI with |
MikeMcQuaid
previously approved these changes
Apr 29, 2021
|
Great work @Bo98! |
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
previously approved these changes
Apr 30, 2021
5 tasks
BrewTestBot
previously approved these changes
May 4, 2021
|
Added a tweak to address #11108. |
MikeMcQuaid
previously approved these changes
May 4, 2021
| # Use keyword args instead of positional args for initialization. | ||
| def initialize(**kwargs) | ||
| super(*members.map { |k| kwargs[k] }) | ||
| class Relocation |
There was a problem hiding this comment.
Worth having any basic unit tests for this class?
7 tasks
|
Note to self: follow up on cleanup comments from #11331 (comment) when this is merged. |
BrewTestBot
previously approved these changes
May 10, 2021
BrewTestBot
previously approved these changes
May 10, 2021
BrewTestBot
approved these changes
May 10, 2021
5 tasks
7 tasks
5 tasks
5 tasks
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
May 14, 2021
Fixes CI failure seen in Homebrew#76444 and various other PRs. Also, update the license. There are no "or later" references in the source repository. See Homebrew/brew#11286.
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
May 14, 2021
Fixes CI failure seen in Homebrew#77228 and various other PRs. Also, update the license, and use `https` in homepage. See Homebrew/brew#11286. License ref: https://metadata.ftp-master.debian.org/changelogs//main/m/monkeysphere/monkeysphere_0.44-1_copyright
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
May 14, 2021
Fixes CI failure seen in #76444 and various other PRs. Also, update the license. There are no "or later" references in the source repository. See Homebrew/brew#11286. Closes #77243. Signed-off-by: Sean Molenaar <[email protected]> Signed-off-by: BrewTestBot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?See #11227 and #11275.
Commits are split to make it easier to review.