Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use our own libarchive in lanraragi #183698

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Use our own libarchive in lanraragi #183698

merged 3 commits into from
Sep 6, 2024

Conversation

fxcoudert
Copy link
Member

See #183626 and #181569, there are good reasons to use our own libarchive everywhere rather than depend on Apple's:

  • consistency
  • Apple's version lacks headers, which makes formulas more complex
  • Apple's version is old, provided only for backward compatibility, and lacks some functionality

@fxcoudert fxcoudert requested review from MikeMcQuaid and a team as code owners September 6, 2024 08:56
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 6, 2024
@bugdea1er bugdea1er mentioned this pull request Sep 6, 2024
Closed
1 task
MikeMcQuaid
MikeMcQuaid approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Sep 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 6, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 6, 2024
Merged via the queue into Homebrew:master with commit a9ad111 Sep 6, 2024
15 checks passed
@fxcoudert fxcoudert deleted the lanraragi branch September 6, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@bugdea1er bugdea1er bugdea1er left review comments

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fxcoudert @MikeMcQuaid @bugdea1er @carlocab @BrewTestBot