Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micromamba: use libarchive from homebrew #183626

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

bugdea1er
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Hi there!

As discussed in #181569, there is some inconsistency with the use of libarchive in the formulas.

This pull request replaces the libarchive dependency from macOS with homebrew's. This leaves lanraragi as the only one left with uses_from_macos "libarchive"

@bugdea1er
Copy link
Contributor Author

bugdea1er commented Sep 5, 2024

While I don't like the idea of ​​installing a library when we already have it built in, at least this will make everything more consistent

@fxcoudert
Copy link
Member

Apple ships the library in an incomplete way, and it's an older version. Let's go!

Copy link
Contributor

github-actions bot commented Sep 6, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 6, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 6, 2024
Merged via the queue into Homebrew:master with commit fea05fe Sep 6, 2024
15 checks passed
@bugdea1er bugdea1er deleted the micromamba-libarchive branch September 6, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants