Update signal to 1.23.1

[ahousseini]

After making all changes to the cask:

• brew cask audit --download {{cask_file}} is error-free.
• brew cask style --fix {{cask_file}} left no offenses.
• The commit message includes the cask’s name and version.

[core-code]

these damaged zip files are becoming more common. i had the idea of fixing them in a 'preflight' stanza (search for 0x06054b50 and remove the additional bytes), but it seems 'preflight' is run after decompression...

[vitorgalvao]

@core-code Maybe switching to something other than unzip (like ditto) will work.

[core-code]

@vitorgalvao i can confirm that using 'ditto -xk' to extract 'signal-desktop-mac-1.23.1.zip' works and produces a launchable app that is bit-for-bit identical with the one that the macOS GUI unarchiver produces.

[vitorgalvao]

@reitermarkus How about changing the unzipping strategy to use ditto? What stops us, if anything?

[reitermarkus]

The problem is some things fail with ditto and some fail with unzip. We already use ditto as a fallback for a specific type of error.

[core-code]

it seems upstream doesn't want to fix this, so we need a solution or a workaround in HBC.

i propose a workaround by adding

container type: :naked
…
preflight do
	    system_command '/usr/bin/ditto', args: ['-xk', staged_path.join(filename), staged_path]
end

see #61140 for my try to get signal working this way.

[vitorgalvao]

it seems upstream doesn't want to fix this, so we need a solution or a workaround in HBC.

Homebrew/brew#5954

[core-code]

sorry didn't see that a real solution was already in-progress