-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: multiple URLs per Cask #3043
Conversation
Cask |
- Work-in-progress because there are no docs/tests at present. Some current tests fail. - Permits `url` stanza to be repeated multiple times - checksum keys such as `:sha256` may be appended to each `url` - `:target` may be appended to `url` to specify a target download name, with special value `:basename` indicating the basename extracted from the URL - `:multipart => true` may be appended to `url` to indicate assets which will not be subjected to container analysis or explicit unarchiving. `:multipart` may not be the best name for that. `:fetch_only` ?
Cask |
@rolandwalker The idea is interesting but I would prefer something that allows one to compose the formula's URL by given parameters. So I would have something like: And then: Not sure if there's already a way of doing what I've purposed, just making a comment on something I was just wondering and want to hear your thoughts on that. |
@rafaelrinaldi , I'm interested in all the possibilities! Your proposal sounds useful in several contexts. The PR where we are having this discussion was intended more for cases like distributions which logically belong together but happen to comprise multiple URLs. Examples: Multi-file RAR archives, Font families. So I hadn't thought about CLI flags to select only a subset in this context. However, we definitely plan on doing something along the lines of #2657 which brought you here (and would have already if we had more coders and more time). That form would very naturally match up with the CLI flags you propose: localization('cn') do
<cask elements>
end
os_version('10.8') do
<cask elements>
end and then $ brew cask install my-formula --os_version=10.8 However, as I said above the string interpolation you describe can also be useful. And to an extent, it is available now, though
url "http://foo.com/bar/#{MacOS.version}/image.dmg" |
There's a lot going on in this PR, but I think we can split it up and salvage the parts we think are still useful. In particular, the |
I also see that as an attractive feature. More specifically, the only attractive feature. Multiple urls and the other options like
|
Closing for lack of interest, and because the implementation is vastly out of date at this point. |
url
stanza to be repeated multiple times:sha256
may be appended to eachurl
:target
may be appended tourl
to specify a target download name,with special value
:basename
indicating the basename extracted from the URL:multipart => true
may be appended tourl
to indicate assets which willnot be subjected to container analysis or explicit unarchiving.
:multipart
may not be the best name for that.
:fetch_only
?