Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better solution than subversion for fonts? #16231

Closed
vitorgalvao opened this issue Dec 30, 2015 · 4 comments
Closed

Better solution than subversion for fonts? #16231

vitorgalvao opened this issue Dec 30, 2015 · 4 comments

Comments

@vitorgalvao
Copy link
Member

From #16215 (comment).

The reason we’re doing it this way is svn, unlike git, allows us to checkout a single directory from the repo, making for a smaller download.

Download size in itself isn’t that big a deal, I’d say, since worst case scenario the download of a full fonts repo should be ≈250MBs (Google Fonts) and there are bigger apps. With caching, and since users likely don’t install fonts all the time, that wouldn’t be a huge deal, except that since we need to separate apps by directory before linking (moving, in the future) we’d leave users with a bunch of copies of those uncompressed repos, and that is not good.

However, using subversion in this manner is in itself bad for casks, I’d argue, since it requires an important additional value to urls. This subversion revision value is (seems like) an obtuse parameter to get in the context of a github repo, and I’m not even sure there’s an easy way for contributors to know when to updated it and to what value. It also makes the cask somewhat more difficult to understand in the sense that its url value will seem to lead nowhere.

In light of all this, I’d rather have yet a different solution. I briefly considered a sibling project, like our sister alehouse to host these multiple-fonts-per-repo fonts. I was envisioning a script that regularly would download those repos, package fonts as individual zip files, and push them to a github repo. Corresponding cask font files would then be set to :latest (fonts is one case where you absolutely always want the latest) and download from there. Those wouldn’t really be official links, though, and there may be other things I’m also not predicting there.

Any ideas?

@jawshooah
Copy link
Contributor

That would require multiple URLs per cask, which we don't support at the moment, and would probably require a good bit of rearchitecting.

@adidalal
Copy link
Contributor

adidalal commented Jan 1, 2016

I never said that it was a good idea 😉

I'm actually surprised there is isn't a better solution for fonts - i would expect Google to have at least a downloadable zip per font somewhere....

@vitorgalvao
Copy link
Member Author

I'm actually surprised there is isn't a better solution for fonts - i would expect Google to have at least a downloadable zip per font somewhere....

They do, on the Google Fonts directory but we’d have to go and grab them one by one since each has a different hash in the download link, and I’m not even sure they aren’t temporary.

There are other repos with multiple fonts, however, so doing that wouldn’t in itself solve the problem.

@miccal miccal removed the discussion label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants