Use plist main binary for Rosetta audit #18109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `brew audit` only audits the first binary in a cask. For example the cask `wiso-steuer-2024` contains multiple binaries in `Contents/MacOS`: - `btssysteminfo` - `whilfe` - `wmain24` The first binary (some telemetry tool) is not the main binary and not a universal binary, but the other two are. Given that `wmain24` is defined as the main binary in the `Contents/Info.plist`, brew probably should audit that binary rather than just checking the first one.
leipert
force-pushed
the
leipert-fix-rosetta-audit
branch
from
db877b9 to
8814a49
Compare
|
@MikeMcQuaid / @SMillerDev WDYT about this follow-up to #17573 ? |
8 tasks
leipert
commented
Aug 21, 2024
MikeMcQuaid
approved these changes
Aug 21, 2024
|
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @leipert! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
brew auditonly audits the first binary in a cask. For example the caskwiso-steuer-2024contains multiple binaries inContents/MacOS:btssysteminfowhilfewmain24The first binary (some telemetry tool) is not the main binary and not a universal binary, but the other two are. Given that
wmain24is defined as the main binary in theContents/Info.plist, brew probably should audit that binary rather than just checking the first one.brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?