-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check if casks should warn about rosetta #17573
feat: check if casks should warn about rosetta #17573
Conversation
e681f60
to
d8fbcda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few optional tweaks.
48951aa
to
4a36b31
Compare
Clearly I haven't been a mac user long enough, since I didn't mention Rosetta 2 😄. Did another small addition, and included your changes @MikeMcQuaid |
Thanks @SMillerDev |
4a36b31
to
8dffc31
Compare
8dffc31
to
5fc3af1
Compare
This does not cover the 32-bit intel case from the referenced PR.
In this case rosetta caveat should not be added and another solution is needed instead as mentioned in the other PR. |
Those should be removed:
|
Removed, disabled, or deprecated? pgadmin3 in particular still gets lots of downloads (243 in 30 days). |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This should warn in cases like Homebrew/homebrew-cask#177913, so that authors can add the required caveats.