US25987 load balancer and its configuration #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reubenur-rahman
changed the title
gandharvas
reviewed
Jun 6, 2022
pkg/client/api.go
Outdated
| @@ -50,6 +50,8 @@ func (a *api) do(ctx context.Context, request interface{}, queryParams map[strin | |||
| panic("api not properly configured") | |||
| } | |||
| a.path = fmt.Sprintf("%s/%s/%s", a.client.getHost(), consts.VmaasCmpAPIBasePath, a.path) | |||
| // a.path = fmt.Sprintf("%s/%s", a.client.getHost(), a.path) | |||
pkg/client/instances_test.go
Outdated
| @@ -64,7 +64,7 @@ func TestInstancesAPIService_CloneAnInstance(t *testing.T) { | |||
| Name: "Instance_Clone", | |||
| } | |||
| // pBody := []byte(`{"zoneId":"1","CloneName":"Instance_Clone"}`) | |||
| m.EXPECT().getVersion().Return(999999) | |||
| m.EXPECT().getVersion().Return(999999).AnyTimes() | |||
There was a problem hiding this comment.
why cant it be specific times??
pkg/common/constants.go
Outdated
| VirtualImagePath = "virtual-images" | ||
| FolderPath = "folders" | ||
| ConfigOptionPath = "config-options" | ||
| PowerSchedulPath = "power-schedules" |
| ProvisionTypesPath = "provision-types" | ||
| RouterRoutePath = "routes" | ||
| RouterBgpNeighborPath = "bgp-neighbors" | ||
| NetworkEdgeClusterPath = "edge-clusters" | ||
|
|
||
| WhoamiPath = "whoami" |
There was a problem hiding this comment.
to maintain consistency over the convention in the file, please add a comment over whoami path
hand written |
gandharvas
previously approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Approving assuming that these changes are validated in the developer's environment.
@Pushpalatha555, please run the ci-suite locally and confirm no issues.
ravikumar29524
approved these changes
Jun 7, 2022
gandharvas
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.