Skip to content

Commit

Permalink
addressed the comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Pushpalatha555 committed Jun 7, 2022
1 parent 6ad9705 commit f9fd56d
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
40 changes: 20 additions & 20 deletions pkg/client/load_balancer.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func (lb *LoadBalancerAPIService) CreateLoadBalancer(
loadBalancerResp := models.CreateNetworkLoadBalancerResp{}
loadBalancerAPI := &api{
method: "POST",
path: fmt.Sprintf("%s/%s", consts.NetworkLoadBalancerPath, consts.LoadBalancerPath),
path: fmt.Sprintf("%s/%s", consts.BasePath, consts.LoadBalancerPath),
client: lb.Client,
jsonParser: func(body []byte) error {
return json.Unmarshal(body, &loadBalancerResp)
Expand All @@ -42,7 +42,7 @@ func (lb *LoadBalancerAPIService) DeleteLoadBalancer(
loadBalancerAPI := &api{
method: "DELETE",
path: fmt.Sprintf("%s/%s/%d",
consts.NetworkLoadBalancerPath, consts.LoadBalancerPath, lbID),
consts.BasePath, consts.LoadBalancerPath, lbID),
client: lb.Client,
jsonParser: func(body []byte) error {
return json.Unmarshal(body, &loadBalancerResp)
Expand All @@ -59,7 +59,7 @@ func (lb *LoadBalancerAPIService) GetLoadBalancers(
loadBalancerResp := models.GetNetworkLoadBalancers{}
loadBalancerAPI := &api{
method: "GET",
path: fmt.Sprintf("%s/%s", consts.NetworkLoadBalancerPath, consts.LoadBalancerPath),
path: fmt.Sprintf("%s/%s", consts.BasePath, consts.LoadBalancerPath),
client: lb.Client,
jsonParser: func(body []byte) error {
return json.Unmarshal(body, &loadBalancerResp)
Expand All @@ -77,7 +77,7 @@ func (lb *LoadBalancerAPIService) GetSpecificLoadBalancers(
loadBalancerResp := models.GetSpecificNetworkLoadBalancer{}
loadBalancerAPI := &api{
method: "GET",
path: fmt.Sprintf("%s/%s/%d", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d", consts.BasePath,
consts.LoadBalancerPath, lbID),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -97,7 +97,7 @@ func (lb *LoadBalancerAPIService) CreateLBMonitor(
LBMonitorResp := models.CreateLBMonitorResp{}
LBMonitorAPI := &api{
method: "POST",
path: fmt.Sprintf("%s/%s/%d/%s", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerMonitorPath),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -118,7 +118,7 @@ func (lb *LoadBalancerAPIService) DeleteLBMonitor(
LBMonitorAPI := &api{
method: "DELETE",
path: fmt.Sprintf("%s/%s/%d/%s/%d",
consts.NetworkLoadBalancerPath, consts.LoadBalancerPath, lbID,
consts.BasePath, consts.LoadBalancerPath, lbID,
consts.LoadBalancerMonitorPath, lbMonitorID),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -137,7 +137,7 @@ func (lb *LoadBalancerAPIService) GetLBMonitors(
LBMonitorResp := models.GetLBMonitors{}
LBMonitorAPI := &api{
method: "GET",
path: fmt.Sprintf("%s/%s/%d/%s", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerMonitorPath),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -157,7 +157,7 @@ func (lb *LoadBalancerAPIService) GetSpecificLBMonitor(
LBMonitorResp := models.GetSpecificLBMonitor{}
LBMonitorAPI := &api{
method: "GET",
path: fmt.Sprintf("%s/%s/%d/%s/%d", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s/%d", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerMonitorPath, lbmonitorID),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -177,7 +177,7 @@ func (lb *LoadBalancerAPIService) CreateLBProfile(
LBProfileResp := models.CreateLBProfileResp{}
LBProfileAPI := &api{
method: "POST",
path: fmt.Sprintf("%s/%s/%d/%s", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerProfilePath),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -198,7 +198,7 @@ func (lb *LoadBalancerAPIService) DeleteLBProfile(
LBProfileAPI := &api{
method: "DELETE",
path: fmt.Sprintf("%s/%s/%d/%s/%d",
consts.NetworkLoadBalancerPath, consts.LoadBalancerPath, lbID,
consts.BasePath, consts.LoadBalancerPath, lbID,
consts.LoadBalancerProfilePath, lbProfileID),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -217,7 +217,7 @@ func (lb *LoadBalancerAPIService) GetLBProfiles(
LBProfileResp := models.GetLBProfile{}
LBProfileAPI := &api{
method: "GET",
path: fmt.Sprintf("%s/%s/%d/%s", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerProfilePath),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -237,7 +237,7 @@ func (lb *LoadBalancerAPIService) GetSpecificLBProfile(
LBProfileResp := models.GetLBSpecificProfile{}
LBProfileAPI := &api{
method: "GET",
path: fmt.Sprintf("%s/%s/%d/%s/%d", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s/%d", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerProfilePath, lbProfileID),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -257,7 +257,7 @@ func (lb *LoadBalancerAPIService) CreateLBPool(
LBPoolResp := models.CreateLBPoolResp{}
LBPoolAPI := &api{
method: "POST",
path: fmt.Sprintf("%s/%s/%d/%s", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerPoolPath),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -278,7 +278,7 @@ func (lb *LoadBalancerAPIService) DeleteLBPool(
LBPoolAPI := &api{
method: "DELETE",
path: fmt.Sprintf("%s/%s/%d/%s/%d",
consts.NetworkLoadBalancerPath, consts.LoadBalancerPath, lbID,
consts.BasePath, consts.LoadBalancerPath, lbID,
consts.LoadBalancerPoolPath, lbPoolID),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -297,7 +297,7 @@ func (lb *LoadBalancerAPIService) GetLBPools(
LBPoolResp := models.GetLBPools{}
LBPoolAPI := &api{
method: "GET",
path: fmt.Sprintf("%s/%s/%d/%s", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerPoolPath),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -317,7 +317,7 @@ func (lb *LoadBalancerAPIService) GetSpecificLBPool(
LBPoolResp := models.GetSpecificLBPool{}
LBPoolAPI := &api{
method: "GET",
path: fmt.Sprintf("%s/%s/%d/%s/%d", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s/%d", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerPoolPath, lbPoolID),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -337,7 +337,7 @@ func (lb *LoadBalancerAPIService) CreateLBVirtualServers(
LBVSResp := models.LBVirtualServersResp{}
LBVSAPI := &api{
method: "POST",
path: fmt.Sprintf("%s/%s/%d/%s", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerVirtualServersPath),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -358,7 +358,7 @@ func (lb *LoadBalancerAPIService) DeleteLBVirtualServers(
LBVSAPI := &api{
method: "DELETE",
path: fmt.Sprintf("%s/%s/%d/%s/%d",
consts.NetworkLoadBalancerPath, consts.LoadBalancerPath, lbID,
consts.BasePath, consts.LoadBalancerPath, lbID,
consts.LoadBalancerVirtualServersPath, lbVirtualServerID),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -377,7 +377,7 @@ func (lb *LoadBalancerAPIService) GetLBVirtualServers(
LBVSResp := models.GetLBVirtualServers{}
LBVSAPI := &api{
method: "GET",
path: fmt.Sprintf("%s/%s/%d/%s", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerVirtualServersPath),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand All @@ -397,7 +397,7 @@ func (lb *LoadBalancerAPIService) GetSpecificLBVirtualServer(
LBVSResp := models.GetSpecificLBVirtualServers{}
LBVSAPI := &api{
method: "GET",
path: fmt.Sprintf("%s/%s/%d/%s/%d", consts.NetworkLoadBalancerPath,
path: fmt.Sprintf("%s/%s/%d/%s/%d", consts.BasePath,
consts.LoadBalancerPath, lbID, consts.LoadBalancerVirtualServersPath, lbVSID),
client: lb.Client,
jsonParser: func(body []byte) error {
Expand Down
4 changes: 2 additions & 2 deletions pkg/common/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ const (
GroupsPath = "groups"
// NetworksPath
NetworksPath = "networks"
// LoadBalancerPath
NetworkLoadBalancerPath = "api"
// BasePath
BasePath = "api"
// NetworkTypePath
NetworkTypePath = "network-types"
NetworkPoolPath = "pools"
Expand Down

0 comments on commit f9fd56d

Please sign in to comment.