Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quest: building:material #569

Open
wants to merge 9 commits into
base: modified
Choose a base branch
from

Conversation

ravenfeld
Copy link

I'm going to split the request in 2.
#443

Creating a quest to add building material

Screenshot_20240703_105109

@HolgerJeromin
Copy link

Metal, steel and tin is a bit confusing. But yeah, all are in use...

@ravenfeld
Copy link
Author

ravenfeld commented Jul 3, 2024

Yes, I said to myself that I couldn't select a value. Maybe change the message to indicate that only experts can use it?

Or other photos but I myself am not an expert on the subject.

@HolgerJeromin
Copy link

Perhaps drop steel and tin and let metal as the only value.

@ravenfeld
Copy link
Author

@Claurt07 @Un1matr1x

What do you say to these tags?

I like having the choice, especially when I know the subject well. In this case, it would mean that contributors are being forced to use metal, which may or may not be the case.
But I'll let those who contribute to these values tell us what they need.

@mcliquid
Copy link

mcliquid commented Jul 3, 2024

metal is a generic term for a variety of elements and alloys with metallic properties. steel is a solid alloy of iron and carbon. steel is defined in the norm "EN 10020". tin is a soft, silvery-white metal. tin forms verdigris (green mould), which is often found on church roofs (Example).

As a comparison to surface: metal behaves more or less like paved while steel, aluminium or tin are more specific.

@Claurt07
Copy link

Claurt07 commented Jul 3, 2024

@mcliquid thanks for shedding some light on that -- I have to acknowledge I was not clear on the distinction of some of these.
Keeping at least metal or steel and tin (or the three) are good for my use case, as we provide a way for people to specify a form of metal that is generic and one that might be more "vulnerable" than the rest.

@ravenfeld the rest looks good to me! the images are also very illustrative.
I only have another question, should Mud and Adobe be combined and leave only Mud? It is called Adobe where I am from in LATAM, but I wonder if it is not too specific.

@HolgerJeromin
Copy link

@mcliquid
You are right, but the target audience is probably not able to differ steel from other metals...

@mcliquid
Copy link

mcliquid commented Jul 3, 2024

@HolgerJeromin I definitely agree with the target group of StreetComplete. But here we are talking about SCEE - the StreetComplete Expert Edition, right?
My understanding of this version is that we can offer quests here that can go beyond the normal expected level of knowledge, as we can expect the specific target group to intentionally disable such quests (each of which comes with an individual warning) if they are unable to answer them.

@Helium314
Copy link
Owner

I did not have a look at basically anything yet, but please massive reduce image size. This PR alone is adding ~4 megabytes to app size.

Also not sure about the general style when I look at the images. Some of the tags appear to be categories, e.g. metal -> tin+steel, or stone -> sandstone.

Btw what is mirror supposed to mean? "This building is made of mirrors"?

@ravenfeld
Copy link
Author

@mcliquid @Claurt07 @Un1matr1x
Can you help me find more meaningful images? I've looked on the wiki and on wikimedia common. As this is not a quest that I would undertake and as it is taking me a long time to find images, I would like to ask for your help.
Thank you for your help.

@mnalis
Copy link
Collaborator

mnalis commented Jul 8, 2024

TL;DR: perhaps go just with metal (or metal and copper), ignoring other metal-detailed answers.


tin forms verdigris (green mould), which is often found on church roofs (Example).

Actually, it is copper salts that produce that green patina, not tin. Tin is major component of solder, and tin foil is what we used to use to make tin foil hats to protect us from government (or alien) mind-reading devices (or to wrap food) 😃 - although it has mostly been superseded by aluminium foil nowdays, but name stuck.

As for building material, while I generally prefer detailed answers to be available in SCEE, I'm not so sure here.

Basically, only copper is distinctive, other metals not so much. So I'd be fine with just metal (or metal and copper, but that is bound to have people asking questions "why is there copper, and not tin" etc).


Most people (who are not material scientists or are unwilling to scratch the surfaces to determine what it is) will be hard pressed to tell the difference between corrugated galvanized iron (sometimes called "wriggly tin" to add to the confusion, even if Zinc is used for galvanization), steel that has been coated with Zinc-Aluminium, iron/steel coated with thin layer of tin (also known as "Tinplate"), various aluminium alloys (aluminium+manganese, aluminium+magnesium etc.) and steel coated with alloy of lead and tin (also called Tinplate colloquially, but more precisely Terne, even if in original coating there was order of magnitude more lead then tin; but the coating is not load bearing (majority) material anyway).

The use of actual tin as building/roof material is not what one would find in real life, it is too structurally weak. Also, "Tinplates" often do not contain tin at all (and even when they do, it is in micro amounts only for coating, main load bearing material usually being steel; but there are also various aluminum alloys which people might incorrectly call by such "tin" names because of history - just like Tinfoil hat above)

@mcliquid
Copy link

So I'd be fine with just metal

I agree, let's start simple and pick only the significant values. You can always extend a quest later!

@ravenfeld
Copy link
Author

What do you want me to display then?

@mnalis
Copy link
Collaborator

mnalis commented Jul 11, 2024

What do you want me to display then?

Drop steel, tin, copper, metal_plates (but retain generic metal)

@mnalis
Copy link
Collaborator

mnalis commented Sep 9, 2024

As far as I can see, those are several issues mentioned so far that prevent this PR:

@ravenfeld ravenfeld force-pushed the feature/add_building_material branch from 2302c71 to d6e0119 Compare September 28, 2024 19:43
@ravenfeld ravenfeld force-pushed the feature/add_building_material branch from f033369 to 660aee5 Compare November 15, 2024 10:33
@ravenfeld
Copy link
Author

Hello, I'm coming back to my PR. I've used my version a lot, which I've modified, and it's not very good for the community. I'm going to make one PR by one PR to avoid having too many open with you.

I've used ImageOptim (https://imageoptim.com/versions.html
) to compress images, it's simple and local.

@Helium314
Copy link
Owner

Helium314 commented Dec 24, 2024

I've used ImageOptim (https://imageoptim.com/versions.html ) to compress images, it's simple and local.

Thanks, that's a considerable reduction in size!

Comment on lines +740 to +741
<string name="quest_buildingMaterial_title">"What is the overall surface material of building walls here?"</string>
<string name="quest_buildingPartMaterial_title">"What overall material is this building part made of?"</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the building part title also refer to surface material?

<string name="quest_building_material_value_stone">Stone</string>
<string name="quest_building_material_value_glass">Glass</string>
<string name="quest_building_material_value_mirror">Mirror</string>
<string name="quest_building_material_value_mud">Mud</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be named "dried mud" to be more clear.

<string name="quest_building_material_value_metal">Metal</string>
<string name="quest_building_material_value_stone">Stone</string>
<string name="quest_building_material_value_glass">Glass</string>
<string name="quest_building_material_value_mirror">Mirror</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be named "mirrored glass" to be more clear.

<string name="quest_building_material_value_loam">Loam</string>
<string name="quest_building_material_value_marble">Marble</string>
<string name="quest_building_material_value_slate">Slate</string>
<string name="quest_building_material_value_vinyl">Vinyl</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wiki rather explicitly calls this "plastic vinyl strips". Not sure though whether this needs to be mentioned in the text.

@Helium314
Copy link
Owner

This looks mostly fine now, only maybe a few details left, and @Claurt07's question is still open:

I only have another question, should Mud and Adobe be combined and leave only Mud? It is called Adobe where I am from in LATAM, but I wonder if it is not too specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants