-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Quest: building:material #569
base: modified
Are you sure you want to change the base?
Add Quest: building:material #569
Conversation
Metal, steel and tin is a bit confusing. But yeah, all are in use... |
Yes, I said to myself that I couldn't select a value. Maybe change the message to indicate that only experts can use it? Or other photos but I myself am not an expert on the subject. |
Perhaps drop |
What do you say to these tags? I like having the choice, especially when I know the subject well. In this case, it would mean that contributors are being forced to use metal, which may or may not be the case. |
As a comparison to |
@mcliquid thanks for shedding some light on that -- I have to acknowledge I was not clear on the distinction of some of these. @ravenfeld the rest looks good to me! the images are also very illustrative. |
@mcliquid |
@HolgerJeromin I definitely agree with the target group of StreetComplete. But here we are talking about SCEE - the StreetComplete Expert Edition, right? |
I did not have a look at basically anything yet, but please massive reduce image size. This PR alone is adding ~4 megabytes to app size. Also not sure about the general style when I look at the images. Some of the tags appear to be categories, e.g. metal -> tin+steel, or stone -> sandstone. Btw what is |
@mcliquid @Claurt07 @Un1matr1x |
TL;DR: perhaps go just with
Actually, it is copper salts that produce that green patina, not tin. Tin is major component of solder, and tin foil is what we used to use to make tin foil hats to protect us from government (or alien) mind-reading devices (or to wrap food) 😃 - although it has mostly been superseded by aluminium foil nowdays, but name stuck. As for building material, while I generally prefer detailed answers to be available in SCEE, I'm not so sure here. Basically, only copper is distinctive, other metals not so much. So I'd be fine with just Most people (who are not material scientists or are unwilling to scratch the surfaces to determine what it is) will be hard pressed to tell the difference between corrugated galvanized iron (sometimes called "wriggly tin" to add to the confusion, even if Zinc is used for galvanization), steel that has been coated with Zinc-Aluminium, iron/steel coated with thin layer of tin (also known as "Tinplate"), various aluminium alloys (aluminium+manganese, aluminium+magnesium etc.) and steel coated with alloy of lead and tin (also called Tinplate colloquially, but more precisely Terne, even if in original coating there was order of magnitude more lead then tin; but the coating is not load bearing (majority) material anyway). The use of actual |
I agree, let's start simple and pick only the significant values. You can always extend a quest later! |
What do you want me to display then? |
Drop |
As far as I can see, those are several issues mentioned so far that prevent this PR:
|
app/src/main/java/de/westnordost/streetcomplete/quests/building_material/AddBuildingMaterial.kt
Outdated
Show resolved
Hide resolved
2302c71
to
d6e0119
Compare
f033369
to
660aee5
Compare
Hello, I'm coming back to my PR. I've used my version a lot, which I've modified, and it's not very good for the community. I'm going to make one PR by one PR to avoid having too many open with you. I've used ImageOptim (https://imageoptim.com/versions.html |
Thanks, that's a considerable reduction in size! |
<string name="quest_buildingMaterial_title">"What is the overall surface material of building walls here?"</string> | ||
<string name="quest_buildingPartMaterial_title">"What overall material is this building part made of?"</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the building part title also refer to surface material?
<string name="quest_building_material_value_stone">Stone</string> | ||
<string name="quest_building_material_value_glass">Glass</string> | ||
<string name="quest_building_material_value_mirror">Mirror</string> | ||
<string name="quest_building_material_value_mud">Mud</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should be named "dried mud" to be more clear.
<string name="quest_building_material_value_metal">Metal</string> | ||
<string name="quest_building_material_value_stone">Stone</string> | ||
<string name="quest_building_material_value_glass">Glass</string> | ||
<string name="quest_building_material_value_mirror">Mirror</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should be named "mirrored glass" to be more clear.
<string name="quest_building_material_value_loam">Loam</string> | ||
<string name="quest_building_material_value_marble">Marble</string> | ||
<string name="quest_building_material_value_slate">Slate</string> | ||
<string name="quest_building_material_value_vinyl">Vinyl</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wiki rather explicitly calls this "plastic vinyl strips". Not sure though whether this needs to be mentioned in the text.
This looks mostly fine now, only maybe a few details left, and @Claurt07's question is still open:
|
I'm going to split the request in 2.
#443
Creating a quest to add building material