forked from Moloch-Mystics/Baal
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit fixes brian #76
Merged
+227
−74
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f9dca50
QSP-2 Baal Inherits From Non-Upgradeable Contracts: fixing non upgrad…
brossetti1 6bd908d
QSP-3 Integer Overflow / Underflow - remove unchecked on proposalCoun…
brossetti1 e2319d2
QSP-4 Missing Input Validation - reuqiring checks on missed validation
brossetti1 62396f8
QSP-8 Application Monitoring Can Be Improved by Emitting More Events
brossetti1 9b5c4b0
QSP-7 Signed Votes Do Not Expire
brossetti1 3c1792a
QSP-9 setAdminConfig Always Emits Two Events Even if State Is Not Cha…
brossetti1 68e53af
QSP-1 Checkpoints May Not Be Written Correctly (#77)
dekanbro c20ee60
QSP-16 Proposals Can Pass without a Valid Sponsor
brossetti1 67dfe26
updating version recipient
brossetti1 143f9dc
adding nonce to submitVote
brossetti1 cd28a98
adding docs for running coverage
brossetti1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
QSP-7 Signed Votes Do Not Expire
commit 9b5c4b0198df61473fab1a9f92551bbb05402ef0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this is actually an upgrade on the ECDSA logic - there was some signature validations that openzeppelin removed from the ECDSA checks
OpenZeppelin/openzeppelin-contracts@d693d89