Code

Audit fixes brian#76

Code

Merged

brossetti1 merged 11 commits intofeat/baalZodiacHausDAO/Baal:feat/baalZodiacfrom audit-fixes-brianHausDAO/Baal:audit-fixes-brianCopy head branch name to clipboardOct 4, 2022

+227-74

Commits

Commits on Oct 4, 2022

• QSP-2 Baal Inherits From Non-Upgradeable Contracts: fixing non upgradeable dependencies on oz

  brossetti1

  committed
  f9dca50

  Copy full SHA for f9dca50

• QSP-3 Integer Overflow / Underflow - remove unchecked on proposalCount logic

  brossetti1

  committed
  6bd908d

  Copy full SHA for 6bd908d

• QSP-4 Missing Input Validation - reuqiring checks on missed validation

  brossetti1

  committed
  e2319d2

  Copy full SHA for e2319d2

• QSP-8 Application Monitoring Can Be Improved by Emitting More Events

  brossetti1

  committed
  62396f8

  Copy full SHA for 62396f8

• QSP-7 Signed Votes Do Not Expire

  brossetti1

  committed
  9b5c4b0

  Copy full SHA for 9b5c4b0

• QSP-9 setAdminConfig Always Emits Two Events Even if State Is Not Changed.

  brossetti1

  committed
  3c1792a

  Copy full SHA for 3c1792a

• QSP-1 Checkpoints May Not Be Written Correctly (#77)

  Show description for 68e53af
  

  dekanbro

  authored and

  brossetti1

  committed
  68e53af

  Copy full SHA for 68e53af

• QSP-16 Proposals Can Pass without a Valid Sponsor

  brossetti1

  committed
  c20ee60

  Copy full SHA for c20ee60

• updating version recipient

  brossetti1

  committed
  67dfe26

  Copy full SHA for 67dfe26

• adding nonce to submitVote

  brossetti1

  committed
  143f9dc

  Copy full SHA for 143f9dc

• adding docs for running coverage

  brossetti1

  committed
  cd28a98

  Copy full SHA for cd28a98