Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for presence of ed editor #143

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Check for presence of ed editor #143

merged 1 commit into from
Oct 2, 2019

Conversation

mechaniputer
Copy link
Contributor

Intended to address issue #142

@coveralls
Copy link

coveralls commented Oct 1, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 93.111% when pulling e2c9924 on beadleha:master into a7bdf35 on Halibot:master.

richteer
richteer approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@richteer richteer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The comment below makes me think we should consider changing behavior based on the running OS or tool compatibility. I'll let that stand as an exercise for later however

@sjrct sjrct merged commit 2eee903 into Halibot:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richteer richteer richteer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mechaniputer @coveralls @richteer @sjrct