Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh bug when ed is not present #142

Open
mechaniputer opened this issue Oct 1, 2019 · 1 comment
Open

install.sh bug when ed is not present #142

mechaniputer opened this issue Oct 1, 2019 · 1 comment

Comments

@mechaniputer
Copy link
Contributor

The installation script will fail if ed is not installed, but then if ed is then installed after such a failed attempt and the user tries to install again, it will fail indefinitely with no useful information until an uninstall is performed. This manifests on Debian which does not ship ed by default.

@sjrct
Copy link
Member

sjrct commented Oct 1, 2019

tots my b, I remember getting frustrated with sed and then using ed instead. Really though, we should just be using sed, as it is in basically every standard install, which ed is pretty infrequent to be part of the base install.

so, the install script doesn't clean up after itself., which could be a problem generally. I think the fix for this is to just call uninstall here, at least in the case of a fresh install. When overwriting an existing install, maybe we can check updated timestamps, or offer to remove the install? Issue is, if we had a working halibot install and didn't break it, we probably don't want to remove the old install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants