Home page accessibility fixes #664
Conversation
There was a problem hiding this comment.
Great work, Barry! I've added some comments here and there, let me know what you think!
Also, with this PR, I've noticed once again it's a bit difficult to keep all the multilingual templates markup in sync. In the future, it would be great if all the pages inherit the same parametrized template, as it's the same markup after all.
Thanks. Replied to most of them. Hopefully explains my thinking a bit better. Let me know if that makes sense or if you've any more comments on my reasoning.
Yeah it's a bit annoying alright. We probably can do more here to generalise things. I'm honestly hoping to calm down these big PRs soon though... but I've promised that before and then found something else I've wanted to fix! 😉 |
* home page accessibility fixes * Bring home page intro section into index.html * Add fallback background colours * Tidy up responsive sections * Remove fallback colours due to classes on Safari * Add alt text for psuedo content * Add fallback colour incase SVG does not load * Fix typo * Remove alt English text for +/- to avoid translation issues. Fixed properly in #666 * Comment out SVG URL version See HTTPArchive/almanac.httparchive.org#664 (comment) * Move background colour into SVG for consistency * Regenerate base64 banner image
Fixes #663