Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor templates to reduce duplication and assist with Translations #673

Closed
tunetheweb opened this issue Feb 22, 2020 · 0 comments · Fixed by #676
Closed

Refactor templates to reduce duplication and assist with Translations #673

tunetheweb opened this issue Feb 22, 2020 · 0 comments · Fixed by #676
Assignees
Labels
development Building the Almanac tech stack translation world wide web

Comments

@tunetheweb
Copy link
Member

It's been noted a few times (e.g. here, here and here) that there is a lot of duplication of code, especially with the translations and it would be good to refactor these to reduce that and keep the code more maintainable in future.

We should probably have a templates/base/2019/ folder or the like and each translation (including English) can inherit from that and only have the translatable text in each language specific directory rather than the current mix of HTML, JS and Text.

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Feb 22, 2020
@tunetheweb tunetheweb self-assigned this Feb 24, 2020
@tunetheweb tunetheweb changed the title Refactor templates to reduce duplication Refactor templates to reduce duplication and assist with Translations Mar 2, 2020
@tunetheweb tunetheweb added the translation world wide web label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack translation world wide web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant