Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design tweaks #333

Merged
merged 12 commits into from
Nov 6, 2019
Merged

Design tweaks #333

merged 12 commits into from
Nov 6, 2019

Conversation

ymschaap
Copy link
Contributor

@ymschaap ymschaap commented Nov 5, 2019

I'm not sure who is now working on fine tuning the styling. But e.g. for mobile it needed a few fixes to not overflow the viewport.

I propose these changes:

  • smoother font
  • less large h1 + return of the stripe
  • mobile h1 within viewport (smaller)
  • don't overflow viewport (hack for <table>

I could pick up some more mobile changes if interested.

* smoother font
* less large h1 + return of the stripe
* mobile h1 within viewport (smaller)
* don't overflow viewport (hack for <table>
@ymschaap ymschaap requested a review from rviscomi November 5, 2019 15:18
@rviscomi rviscomi added design Creating the Almanac UX development Building the Almanac tech stack labels Nov 5, 2019
@rviscomi rviscomi added this to the SHIP IT! milestone Nov 5, 2019
src/static/css/page.css Show resolved Hide resolved
src/static/css/2019.css Outdated Show resolved Hide resolved
@ymschaap ymschaap requested a review from rviscomi November 6, 2019 09:33
@ymschaap
Copy link
Contributor Author

ymschaap commented Nov 6, 2019

@rviscomi I wrap each <table> node with a <div> using npm run generate.

I did my best of also cleaning up much of the styling that is in different files, and made it more consistent.

Also - for wide screens - I added the content with a max-width. Else it's unreadable :)

I could not center the <tables>, I would need another nested div for that.

@catalinred
Copy link
Member

catalinred commented Nov 6, 2019

@rviscomi @ymschaap
On the responsive <table> matter, what do you think about this solution?
https://codepen.io/lukepeters/pen/bfFur

It's based on using custom HTML attributes data-* and CSS pseudo-elements ::before or ::after in order to stack tables when on a mobile view. It's a classic approach for tables with fixed number of columns and I did use this solution with success in some of my projects.

src/templates/en/2019/chapters/accessibility.html Outdated Show resolved Hide resolved
src/tools/generate/wrap_tables.js Outdated Show resolved Hide resolved
@ymschaap ymschaap requested a review from rviscomi November 6, 2019 14:35
@rviscomi
Copy link
Member

rviscomi commented Nov 6, 2019

On chapter pages <aside> and <figcaption> text appears as 18px while paragraphs are 17px. Is this intentional?

Also H1s may need a bit more line-height on mobile:

image

@rviscomi
Copy link
Member

rviscomi commented Nov 6, 2019

Resolved the merge conflict. Let's get this in and we can iterate on improvements. Thanks for working on this @ymschaap!

@rviscomi rviscomi merged commit 1d9ad38 into master Nov 6, 2019
@rviscomi rviscomi deleted the mobile-fonts-design branch November 6, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Creating the Almanac UX development Building the Almanac tech stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants