Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methodology page has some broken styles #224

Closed
6 of 9 tasks
rviscomi opened this issue Oct 23, 2019 · 8 comments
Closed
6 of 9 tasks

Methodology page has some broken styles #224

rviscomi opened this issue Oct 23, 2019 · 8 comments
Labels
design Creating the Almanac UX development Building the Almanac tech stack enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@rviscomi
Copy link
Member

rviscomi commented Oct 23, 2019

Per #223, there are some CSS tweaks needed on the Methodology page:

  • style the tables
  • ensure tables fit in small viewports
  • add borders under nested list items in the index
  • ensure all links have hover/focus styles (related Add hover/focus states for interactive elements #210)
  • make the index sticky on desktop so it's visible while scrolling (max-height 100% and overflow-y scroll)
  • ensure the H1 has the colored "overline" similar to other pages
  • ensure the hero image is as wide as the hero on chapter pages (866px on desktop)
  • the "index" doesn't open on tap for mobile (important)

The Chapter designs include a mockup of a table that we should implement in 2019.css:

image

And one optional piece of functionality:

  • as the page is scrolled, update the "active" index item with a green highlight (using IntersectionObserver)

cc @MSakamaki

@rviscomi rviscomi added enhancement New feature or request development Building the Almanac tech stack design Creating the Almanac UX labels Oct 23, 2019
@rviscomi rviscomi added this to the SHIP IT! milestone Oct 23, 2019
@rviscomi rviscomi added the good first issue Good for newcomers label Oct 25, 2019
@bkardell
Copy link
Contributor

The head image causes some serious horizontal scrolling on mobile.. that seems probably not specific to this page, but ..

@rviscomi
Copy link
Member Author

I think the image issue was fixed by a recent commit that has not yet been pushed to the live website.

@rviscomi
Copy link
Member Author

rviscomi commented Nov 2, 2019

@HTTPArchive/developers anyone interested in working on this issue? I think this is a fun one (using IntersectionObserver and sticky positioning) 😄

@rviscomi
Copy link
Member Author

rviscomi commented Nov 5, 2019

Assigning @ymschaap who is looking into tables in #333

@rviscomi
Copy link
Member Author

rviscomi commented Nov 9, 2019

@ymschaap are you looking into the remaining TODO items for this issue?

@ymschaap
Copy link
Contributor

ymschaap commented Nov 9, 2019

No sorry, I don't have time available this week to do more work on this.

@ymschaap ymschaap removed their assignment Nov 9, 2019
@rviscomi
Copy link
Member Author

rviscomi commented Nov 9, 2019

No worries, thank you!

@HTTPArchive/developers does anyone have time to look into this?

@rviscomi
Copy link
Member Author

The styles aren't "broken" any more so I'll close this and open a FR for the new improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Creating the Almanac UX development Building the Almanac tech stack enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants