Copyediting PWA chapter #273
Conversation
Co-Authored-By: Jeffrey Posnick <[email protected]>
There was a problem hiding this comment.
Thanks for the iterative changes!
I'd like @tomayac to get a chance to comment as well before moving forward.
Co-Authored-By: Jeffrey Posnick <[email protected]>
Co-Authored-By: Jeffrey Posnick <[email protected]>
Co-Authored-By: Jeffrey Posnick <[email protected]>
Co-Authored-By: Jeffrey Posnick <[email protected]>
|
That's fine @jeffposnick and @tomayac. You definitely should review and I was trying to add a bit more than a simple regurgitation of the rest of the chapter, to make it a bit more interesting and not repetitive but appreciate I may have overstepped the line a little by adding too much of my own opinion rather than concluding yours! Either or both of you are also welcome to have your own stab at this if you have time? Talking of time, I hate to be the one to push you, but can we timebox this so we can get it in next week's launch? What's say we set a deadline to merge after this weekend on Sunday night/Monday morning? Unless you think you can get to it before then? Does that sound OK? And a reminder that you can always file your own PR after that to change it if you wish before launch. |
…rs and reduce chance of bugs
There was a problem hiding this comment.
Thanks for making these changes—I'm not sure if @tomayac will get a chance to review, but I think we're good from my end for getting something committed.
|
@bazzadp can you rerun |
|
Done @rviscomi. Not sure if you're happy for me to go ahead and merge in these instances so will leave to you. |
|
Changed my mind and went ahead and merged so I could work on those SEO fixes. 😀 |
There was a problem hiding this comment.
Thanks for the hard wor reviewing this and sorry if this change request comes in after the merge. @bazzadp, could you still incorporate this suggestion in, please?
(FYI: @jeffposnick @rviscomi)
* Add BreadcrumbList and tweak previous SEO code * Regenerate Chapters * Add descriptions and date stamps * Apply SEO fixes to non-chapter pages * Set Ecommerce chapter as completed, add myself as a developer * Generate Mobile Web HTML * Change publication dates to avoid future dates * Fix HTTP/2 images * Correct Third Parties chapter name * Fix H1 div issue * Further edits from @tomayac as part of #273 * Fix typo * Slight wording changes
Also added a Conclusion section. @tomayac / @jeffposnick it would be good for you to comment on this in next day or two if you can. Don't want to be seen to be putting words in your mouth if you disagree with them!
Part of #218