Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write content: Chapter 11. PWA #164

Closed
3 tasks done
rviscomi opened this issue Sep 17, 2019 · 13 comments · Fixed by #186
Closed
3 tasks done

Write content: Chapter 11. PWA #164

rviscomi opened this issue Sep 17, 2019 · 13 comments · Fixed by #186
Assignees
Labels
ASAP This issue is blocking progress writing Related to wording and content

Comments

@rviscomi
Copy link
Member

rviscomi commented Sep 17, 2019

Part Chapter Authors Reviewers Analysts Metrics Analysis
II. User Experience 11. PWA @tomayac @jeffposnick @HyperPress @jrharalson #13 #92

Due by: October 7

Refer to the Authors' Guide for writing advice.

@rviscomi rviscomi added the writing Related to wording and content label Sep 17, 2019
@rviscomi rviscomi added this to the Content written milestone Sep 17, 2019
@rviscomi
Copy link
Member Author

👋 Greetings! Just checking in to make sure this is progressing and remind you of the October 7 deadline timed so we can launch at Chrome Dev Summit.

The checklist above indicates that you still need to review the results, write content, and get it reviewed. Feel free to reach out if you have any questions about the process.

@tomayac
Copy link
Member

tomayac commented Sep 26, 2019

FYI, work on this chapter has started in this document.

@tomayac
Copy link
Member

tomayac commented Sep 27, 2019

@HyperPress, if you have time, you can have a first read. Still in a very rough shape, but all stats are covered (pending Workbox).

@rviscomi
Copy link
Member Author

rviscomi commented Oct 4, 2019

@tomayac @jeffposnick the doc isn't publicly accessible. I'll start a PR so it's accessible for @HyperPress to review.

@rviscomi rviscomi mentioned this issue Oct 4, 2019
@rviscomi rviscomi added the ASAP This issue is blocking progress label Oct 4, 2019
@tunetheweb
Copy link
Member

I all, I've just started reviewing this chapter as part of #218 and have a few questions/comments. Thought I'd stick them here rather than as their own issue or as part of a PR for the copyedits for now. There will be a PR to come which you all can review and comment on.

@rviscomi there is currently a section on which BigQuery tables the data comes from. Personally I think it should be removed and covered in #202. Also it doesn't mention the Almanac tables. Thoughts?

@tomayac , @jeffposnick and @HyperPress I'm a little confused with some of the stats in the ServiceWorker section:

  • 0.44%/0.37% of pages crawled by HTTPArchive install a Service Worker (which is low as even popular pages are crawled only once - so that's fine).
  • 15% of page loads are service worker controlled
  • 1.56% of lighthouse pages are installable - how does that related to the two stats above? I thought a service worker was a pre-requisite to being installable and would have thought Lighthouse would have run on same set of pages as HTTPArchive as part of that crawl so confused as how it's so different from first stat. Also it's not a measure of all traffic either or it would be closer to second stat. So I'm confused. And think other readers might be too (or I'm just being an idiot). Happy to add a sentence explaining this as part of the copyedit review if you can explain it to me first 😀

I'm also suggesting writing a conclusion section for consistency as most other chapters have that. Want to write this? Or want me to have a stab at it and then you can review as part of the PR?

@rviscomi
Copy link
Member Author

@rviscomi there is currently a section on which BigQuery tables the data comes from. Personally I think it should be removed and covered in #202. Also it doesn't mention the Almanac tables. Thoughts?

Agreed. How we analyze the data is best left for the Methodology page, unless it's particularly relevant to the chapter.

I'm also suggesting writing a conclusion section for consistency as most other chapters have that. Want to write this? Or want me to have a stab at it and then you can review as part of the PR?

To keep things moving go ahead and draft a conclusion and we can iterate on it. Thank you so much for working on this.

I'll leave the SW-specific questions to the others.

@tunetheweb
Copy link
Member

Any thoughts @tomayac , @jeffposnick and @HyperPress ?

@tunetheweb
Copy link
Member

Or @jrharalson who wrote these queries initially?

@tunetheweb
Copy link
Member

OK it would appear that these are separate requirements.

https://web.dev/installable-manifest/ states that you need basically four things to be installable:

  1. Manifest
  2. HTTPS
  3. Service Worker
  4. Some sort of engagement

I was presuming a Service Worker was part of the "Installable Manifest" criteria but it appears it's part of the larger "Installable" criteria. I don't think this is clear so have raised an issue for this.

Many sites have an installable manifest but no service worker. For example https://www.dropee.com/ gets the following in Lighthouse:

image

55,000 sites are in this category in HTTPArchive's July 2019 run meet this criteria (warning this query uses 1.22TB so don't run unless you have a good amount of credit!):

SELECT *
FROM `httparchive.lighthouse.2019_07_01_mobile`
WHERE JSON_EXTRACT_SCALAR(report, '$.audits.installable-manifest.score') = '1'
and JSON_EXTRACT_SCALAR(report, '$.audits.service-worker.score') = '0'

In fact only 20,000 sites meet both critera (uses a service worker and is installable) so just looking at installable manifests is over reporting by a large factor - which is exactly what we saw in this report and what confused me.

Will make some edits to the text to make this clear for any others like me who are easily confused.

@jeffposnick
Copy link
Contributor

Hello @bazzadp! Thanks for your thorough reviews.

In fact only 20,000 sites meet both critera (uses a service worker and is installable) so just looking at installable manifests is over reporting by a large factor - which is exactly what we saw in this report and what confused me. Will make some edits to the text to make this clear for any others like me who are easily confused.

Thanks, that sounds like a reasonable edit to make—reporting on how many sites actually meet all four of those conditions for installability sounds like a more meaningful stat than reporting on how many just meet the manifest criteria. (I wasn't fully aware of those distinctions in the way Lighthouse reported that data either.)

I'm also suggesting writing a conclusion section for consistency as most other chapters have that. Want to write this? Or want me to have a stab at it and then you can review as part of the PR?

I'm not familiar with the style/tone used in the conclusion of the other chapters, so if you are and feel comfortable taking a stab at it, that would be great. Happy to review it after the fact.

@tunetheweb
Copy link
Member

Have done @jeffposnick as part of #273. Comments appreciated but hoping to launch next week so if you could reviewer sooner rather than later then that would be appreciated!!

@rviscomi
Copy link
Member Author

@tomayac @jeffposnick sorry for the delay, but this chapter finally has its data viz. Check it out here: https://almanac.httparchive.org/en/2019/pwa

Thanks again for your contributions! 👍 👍

@tomayac
Copy link
Member

tomayac commented Nov 17, 2019

This looks beautiful, thank you very much for your hard work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP This issue is blocking progress writing Related to wording and content
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants