-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write content: Chapter 11. PWA #164
Comments
👋 Greetings! Just checking in to make sure this is progressing and remind you of the October 7 deadline timed so we can launch at Chrome Dev Summit. The checklist above indicates that you still need to review the results, write content, and get it reviewed. Feel free to reach out if you have any questions about the process. |
FYI, work on this chapter has started in this document. |
@HyperPress, if you have time, you can have a first read. Still in a very rough shape, but all stats are covered (pending Workbox). |
@tomayac @jeffposnick the doc isn't publicly accessible. I'll start a PR so it's accessible for @HyperPress to review. |
I all, I've just started reviewing this chapter as part of #218 and have a few questions/comments. Thought I'd stick them here rather than as their own issue or as part of a PR for the copyedits for now. There will be a PR to come which you all can review and comment on. @rviscomi there is currently a section on which BigQuery tables the data comes from. Personally I think it should be removed and covered in #202. Also it doesn't mention the Almanac tables. Thoughts? @tomayac , @jeffposnick and @HyperPress I'm a little confused with some of the stats in the ServiceWorker section:
I'm also suggesting writing a conclusion section for consistency as most other chapters have that. Want to write this? Or want me to have a stab at it and then you can review as part of the PR? |
Agreed. How we analyze the data is best left for the Methodology page, unless it's particularly relevant to the chapter.
To keep things moving go ahead and draft a conclusion and we can iterate on it. Thank you so much for working on this. I'll leave the SW-specific questions to the others. |
Any thoughts @tomayac , @jeffposnick and @HyperPress ? |
Or @jrharalson who wrote these queries initially? |
OK it would appear that these are separate requirements. https://web.dev/installable-manifest/ states that you need basically four things to be installable:
I was presuming a Service Worker was part of the "Installable Manifest" criteria but it appears it's part of the larger "Installable" criteria. I don't think this is clear so have raised an issue for this. Many sites have an installable manifest but no service worker. For example https://www.dropee.com/ gets the following in Lighthouse: 55,000 sites are in this category in HTTPArchive's July 2019 run meet this criteria (warning this query uses 1.22TB so don't run unless you have a good amount of credit!):
In fact only 20,000 sites meet both critera (uses a service worker and is installable) so just looking at installable manifests is over reporting by a large factor - which is exactly what we saw in this report and what confused me. Will make some edits to the text to make this clear for any others like me who are easily confused. |
Hello @bazzadp! Thanks for your thorough reviews.
Thanks, that sounds like a reasonable edit to make—reporting on how many sites actually meet all four of those conditions for installability sounds like a more meaningful stat than reporting on how many just meet the manifest criteria. (I wasn't fully aware of those distinctions in the way Lighthouse reported that data either.)
I'm not familiar with the style/tone used in the conclusion of the other chapters, so if you are and feel comfortable taking a stab at it, that would be great. Happy to review it after the fact. |
Have done @jeffposnick as part of #273. Comments appreciated but hoping to launch next week so if you could reviewer sooner rather than later then that would be appreciated!! |
@tomayac @jeffposnick sorry for the delay, but this chapter finally has its data viz. Check it out here: https://almanac.httparchive.org/en/2019/pwa Thanks again for your contributions! 👍 👍 |
This looks beautiful, thank you very much for your hard work on this! |
Due by: October 7
Refer to the Authors' Guide for writing advice.
The text was updated successfully, but these errors were encountered: