Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA chapter #186

Merged
merged 9 commits into from
Oct 5, 2019
Merged

PWA chapter #186

merged 9 commits into from
Oct 5, 2019

Conversation

rviscomi
Copy link
Member

@rviscomi rviscomi commented Oct 4, 2019

@rviscomi rviscomi added the writing Related to wording and content label Oct 4, 2019
@rviscomi rviscomi added this to the Content written milestone Oct 4, 2019
@rviscomi rviscomi requested a review from logicalphase October 4, 2019 15:03
@tomayac
Copy link
Member

tomayac commented Oct 4, 2019

As announced over email, I’m OoO the next two weeks and hope @jeffposnick can help move this over the finish line.

Copy link
Member

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor nitpicks mostly grammatical and such.

Looks good to me!

src/content/en/2019/pwa.md Outdated Show resolved Hide resolved
src/content/en/2019/pwa.md Outdated Show resolved Hide resolved
src/content/en/2019/pwa.md Show resolved Hide resolved
src/content/en/2019/pwa.md Outdated Show resolved Hide resolved
src/content/en/2019/pwa.md Show resolved Hide resolved
src/content/en/2019/pwa.md Outdated Show resolved Hide resolved
src/content/en/2019/pwa.md Show resolved Hide resolved
src/content/en/2019/pwa.md Outdated Show resolved Hide resolved
src/content/en/2019/pwa.md Show resolved Hide resolved
src/content/en/2019/pwa.md Outdated Show resolved Hide resolved
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
@rviscomi
Copy link
Member Author

rviscomi commented Oct 4, 2019

A couple of minor nitpicks mostly grammatical and such.

Thanks @ahmadawais! To confirm, you've also given it a review for technical correctness?

@ahmadawais
Copy link
Member

Yes, to the best of my knowledge. I don't see the images in there. But it was an interesting read. 👍

@rviscomi
Copy link
Member Author

rviscomi commented Oct 4, 2019

Ah that's right. This PR is a markdown version of the doc authored by Tom and Jeff: https://docs.google.com/document/d/1MOt6doqXdL1yrvZvpRIDv37ulFpUBBj1cxLi_l8k1gQ/edit?usp=sharing

You'll need to request view access though.

Alternatively, the charts are based on this public spreadsheet. Each tab has a metric ID that corresponds with the chart placeholders in the markdown.

@ahmadawais
Copy link
Member

Yes, I just requested access. Do I need to do the same for the Media chapter? Can you share its doc link? And yes, I have already checked the Web Almanac: PWA Analysis sheet.

@tomayac
Copy link
Member

tomayac commented Oct 4, 2019

Access to the document was granted, thanks @ahmadawais.

@rviscomi
Copy link
Member Author

rviscomi commented Oct 4, 2019

Great, thanks again @ahmadawais. Leaving this PR open for @HyperPress to review.

@logicalphase
Copy link
Contributor

logicalphase commented Oct 4, 2019

Will review after work. Thanks. I went ahead and applied mostly nit changes. The remainder looks good. I'd like to see the file in all it's glory. Please let me know when I can access it and will handle this evening.

HyperPress and others added 6 commits October 4, 2019 16:32
Nits and such. I concur.

Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
@logicalphase
Copy link
Contributor

Full review. PWA information is logically presented and accurate. Great work that users will no doubt find instructive.

@logicalphase logicalphase merged commit 0dec838 into master Oct 5, 2019
@logicalphase logicalphase deleted the pwa-chapter branch October 5, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write content: Chapter 11. PWA
5 participants