-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA chapter #186
PWA chapter #186
Conversation
As announced over email, I’m OoO the next two weeks and hope @jeffposnick can help move this over the finish line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor nitpicks mostly grammatical and such.
Looks good to me!
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Thanks @ahmadawais! To confirm, you've also given it a review for technical correctness? |
Yes, to the best of my knowledge. I don't see the images in there. But it was an interesting read. 👍 |
Ah that's right. This PR is a markdown version of the doc authored by Tom and Jeff: https://docs.google.com/document/d/1MOt6doqXdL1yrvZvpRIDv37ulFpUBBj1cxLi_l8k1gQ/edit?usp=sharing You'll need to request view access though. Alternatively, the charts are based on this public spreadsheet. Each tab has a metric ID that corresponds with the chart placeholders in the markdown. |
Yes, I just requested access. Do I need to do the same for the Media chapter? Can you share its doc link? And yes, I have already checked the |
Access to the document was granted, thanks @ahmadawais. |
Great, thanks again @ahmadawais. Leaving this PR open for @HyperPress to review. |
Will review after work. Thanks. I went ahead and applied mostly nit changes. The remainder looks good. I'd like to see the file in all it's glory. Please let me know when I can access it and will handle this evening. |
Nits and such. I concur. Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Co-Authored-By: Ahmad Awais ⚡️ <[email protected]>
Full review. PWA information is logically presented and accurate. Great work that users will no doubt find instructive. |
Closes #164
cc @jeffposnick @tomayac