Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend height of AMP Stories images #1957

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Extend height of AMP Stories images #1957

merged 2 commits into from
Feb 1, 2021

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Feb 1, 2021 •
edited
Loading

Getting alerts in Google Search Console:

image

The requirements for AMP articles are:

  • Images need to be 1200 width - we're all good here
  • Images need to 800,000 pixels - ours fall short at 1200 x 600 = 720,000
  • For best results, provide multiple high-resolution images (minimum of 800,000 pixels when multiplying width and height) with the following aspect ratios: 16x9, 4x3, and 1x1.

So let's change our web stories images from 1200 x 600 to 1200 x 675 (which is 16x9) to solve this. All I've done is padded the images with 75px of grey background.

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Feb 1, 2021
@tunetheweb tunetheweb added this to the 2020 Backlog milestone Feb 1, 2021
@tunetheweb tunetheweb merged commit 672d056 into main Feb 1, 2021
@tunetheweb tunetheweb deleted the stories-image-min-pixels branch February 1, 2021 15:34
chefleo added a commit to chefleo/almanac.httparchive.org that referenced this pull request Feb 1, 2021
@chefleo
Merge remote-tracking branch 'upstream/main' into main
2fe5d18 
* upstream/main: (70 commits)
  Do fuller HTML linting checks on generated HTML (HTTPArchive#1959)
  Extend height of AMP Stories images (HTTPArchive#1957)
  Change Introductie to Inleiding (HTTPArchive#1956)
  Bump peter-evans/create-pull-request from v3.7.0 to v3.8.0 (HTTPArchive#1955)
  Update Timestamps and Generate Ebooks (HTTPArchive#1953)
  Update total number of pages in ebook to 600! (HTTPArchive#1952)
  Remove control characters causing HTML validation errors (HTTPArchive#1951)
  2020 javascript japanese translation (HTTPArchive#1937)
  Translation of 2020 accessibility chapter to Japanese (HTTPArchive#1949)
  Fix figure links and footnotes for ebook (HTTPArchive#1950)
  Fix hide description bug (HTTPArchive#1948)
  Update Timestamps and Generate Ebooks (HTTPArchive#1947)
  Smart Quotes for English non-chapter pages (HTTPArchive#1946)
  Typographical quotes for metadata (HTTPArchive#1945)
  Fix figure number bug (HTTPArchive#1944)
  Update Timestamps and Generate Ebooks (HTTPArchive#1943)
  Revert "Revert "Add typographic punction conversion"" (HTTPArchive#1942)
  Add Nuxt and Docusauraus to Jamstack 2020 chapter (HTTPArchive#1938)
  Revert "Add typographic punction conversion"
  Add typographic punction conversion
  ...
This was referenced Feb 6, 2021
Merged
Merged
@tunetheweb tunetheweb mentioned this pull request Feb 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
development Building the Almanac tech stack
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
1 participant
@tunetheweb