Add typographic punctuation #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5a46df3.
tunetheweb
added
development
|
OK not surprising that template changes are too big with this, so going to ignore that failed test as that's the reason it failed. |
chefleo
added a commit
to chefleo/almanac.httparchive.org
that referenced
this pull request
Feb 1, 2021
* upstream/main: (70 commits) Do fuller HTML linting checks on generated HTML (HTTPArchive#1959) Extend height of AMP Stories images (HTTPArchive#1957) Change Introductie to Inleiding (HTTPArchive#1956) Bump peter-evans/create-pull-request from v3.7.0 to v3.8.0 (HTTPArchive#1955) Update Timestamps and Generate Ebooks (HTTPArchive#1953) Update total number of pages in ebook to 600! (HTTPArchive#1952) Remove control characters causing HTML validation errors (HTTPArchive#1951) 2020 javascript japanese translation (HTTPArchive#1937) Translation of 2020 accessibility chapter to Japanese (HTTPArchive#1949) Fix figure links and footnotes for ebook (HTTPArchive#1950) Fix hide description bug (HTTPArchive#1948) Update Timestamps and Generate Ebooks (HTTPArchive#1947) Smart Quotes for English non-chapter pages (HTTPArchive#1946) Typographical quotes for metadata (HTTPArchive#1945) Fix figure number bug (HTTPArchive#1944) Update Timestamps and Generate Ebooks (HTTPArchive#1943) Revert "Revert "Add typographic punction conversion"" (HTTPArchive#1942) Add Nuxt and Docusauraus to Jamstack 2020 chapter (HTTPArchive#1938) Revert "Add typographic punction conversion" Add typographic punction conversion ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1485
This converts simple quotes (" and ') to typographic quotes (“,”, and ‘’), sometimes know as curly quotes or smart quotes.
It does this using the smartypants library. I tried a few of these, and this one was the only one I could get working consistently as it ignores code formatting and comments.
Still needs a little fudging for our Jinja2 macros (figure markup) but actually quite clean.
I also fixed a lot of captions and descriptions to allow them to be typographic quotes too.
Currently it only handles English punctuation so translations for languages with different punctuation marks still need to convert.