-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy edit of 2020 CSS chapter #1846
Conversation
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 16.1%, saving 202 bytes.
773 images did not require optimisation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlighted the TODOs for your comment.
BTW forgot to say - fantastic chapter. Very interesting and very readable even for someone like me with limited CSS knowledge (other than the colour gamut stuff that went completely over my head 😀)! So really well done given the amount you covered!
Let me know your thoughts on the points I've highlighted with TODOs and feel free to suggest changes via GitHub or to just push suggestions directly to this branch.
I notice that the advance release of the almanac used the small color table rather than the much bigger table from the >100k re-run. The difference is significant, the first run found only 23 unique pairs of (P3, sRGB) colors while the re-run found 114. |
Sorry about that. So, this was the explanation I used (trying to keep it short, but apparently it wasn't understandable enough):
Gamut is "the range of colors that can be displayed" and a narrower gamut means less colors (omitting the more vivid ones). Suggestions to re-word that would be welcome. Maybe "Because it has a small gamut (it can only display a limited range of colors)" makes it clearer? Or was it the chromaticity diagram or the use of deltaE that was unclear? I felt it was important to capture this data, despite p3 colors being barely used, because this is expected to increase over then next few years and therefore this year is the baseline to compare against. |
Could we link to this instead? I feel the full table would be quite large, and having it in a spreadsheet makes it easier to copy and paste and use fiddle with the data if you want. Plus there's a bug in our PDF generator that doesn't like tables spanning more than one page 😀 I've copied the data to your spreadsheet and added a link to figcaption in 97d3ed5 and you can see what that looks like here: https://20201228t110002-dot-webalmanac.uk.r.appspot.com/en/2020/css#fig-29 WDYT?
I get the basic concept but the finer details were a little lost on me, but that's OK. What's more concerning is I didn't really get the point you were trying to make. Did you see my comment in #1846 (comment)? You may have to click this to see the rest of my comments: Here's what I said:
|
I did now :) |
What is the timescale for reviewing these comments? |
Depends how keen you are to remove the "Unedited" label 😁 Sooner would be better rather than later though as now is when it gets a lot of views. We can have a look after the majority are answered/resolved/not doing and decide if it's basically edited now and and leave one or two till later. |
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
…chive.org into cs-2020-edits
Italics and bold help chunking, which makes text easier to process than one blob of uniform text, and more pleasant to read. They are the typographic equivalent of formatting a long phone number with dashes and parentheses instead of presenting it as a series of numbers. It is not a good idea to remove them. |
Personally I disagree - that's what punctuation is for. Italics and bold are for emphasis and (IMHO) they are often overused for this. Some style guides agree, though the Google Developer Documentation Style Guide isn't quite a clear on the subject as that. For the Web Almanac we use italics to introduce a new technical term and (very sparingly) for emphasis. We also have the "big figures" for emphasising important or interesting stats and this is better to me in that it also links back to the data and queries to back that up. Now there is a balance between celebrating the fact we have different, and diverse authors (and so writing style!) for each chapter, and trying to have a consistency across all the chapters. That's something we try to address in the editing process and yes it does lead to tough calls and disagreement when writing styles clash. I feel this is one point we should be consistent on to avoid confusing readers when one chapter uses bold and italics for one reason, and another for another. If you look across the other chapters bold and italics are not used much at all (and only sometimes has that been because editors have removed them!) But more than willing to admit I could have got it wrong in places, so if there's particular ones you want to bring back then please add comment in Files tab and we can discuss, but I'd personally be against bringing back all the ones I removed as I really do feel they distracted, more than helped. I'd be interested to hear others opinion on this too (as long as you three authors don't gang up on this one poor, wannabe editor! 😀) — especially @rachelandrew given her professional editing experience. |
@svgeesus @LeaVerou @rachelandrew keen to close this out and removed the Unedited tag from the label. Could you look over the remaining open issues and see if we can merge this soon? |
@bazzadp I'll take a look at any of these things that relate to my bits. With regard to extensive use of bold and italics, I'm not a fan, and remove them when editing. In general, if a paragraph is so long that you need to add bold to "chunk" it, it might be better to split it into two sections, add a heading or example. Quite a lot of people also find italicised text difficult to read in large blocks. Bold and italic also infer some kind of meaning, but what? If the section needs calling out in some way it would be better to have an option to highlight it (something to make it a note, or warning perhaps). When I'm editing, if I see a section in bold, that's a flag for me to ask the author why they thought that bit was so important it should be in bold. Perhaps instead they could explain why it was so important, rather than just wave an important flag by way of emboldening the text. |
Have you had a chance to look at this yet @rachelandrew ? I really would like to close this out ASAP even if it means merging this PR and addressing the last few items in future. |
@bazzadp I didn't see anything related to the sections I had worked on. Have I missed something? |
Sorry I'm not aware of who worked on what, so was only following up on your comment when you said you'd close out anything related to your bits. There's still a few unresolved items above but guess they are for @LeaVerou or @svgeesus then. From your end I presume you're happy to merge this @rachelandrew and that I haven't butchered your writing too much? 😀 |
I think we may be talking about different things. I do not support overuse of bold and italics, as they defeat the purpose and dilute their meaning. However, when used appropriately, they can increase scannability, reduce cognitive load, and make a paragraph easier to process. I also did not advocate for entire sections in bold. |
Thanks @LeaVerou appreciate it. It would be good to get this closed out so I can stop pestering you all! Really do appreciate the huge effort that’s gone into this already but this should hopefully be the last piece! As I said earlier I’m happy to reintroduce any of the bolds and italics you feel are necessary if you want to make those edits in this branch. Maybe I was too aggressive removing some of them but honesty didn’t think at least some of them were necessary and think Rachel’s covered some of my thinking here. But I’ve been wrong before (and definitely will be again!) and it’s your names at the top, so want you to be comfortable with any edits made and revert any you’re not comfortable with. |
Oh and huge congrats on your election to W3C Tag!! Very well deserved! |
I just went through and left comments. I'm not sure what kind of intro text to add to prevent adjacent headings. I suppose I'm not used to adding blurbs with no purpose just for cosmetic reasons. However, I'm fine with whatever you or anyone else wants to add. Another issue with removing italic and bold is that it makes the implied voice of the text flat and boring. Compare this:
with this:
Read it out. Do you see the difference in tone? I also disagree with a few of the style guide decisions, but didn't leave comments on those as I suspect it's a losing battle. But for the record:
|
Thank you! |
I made an attempt in 34ba57b Empty or "Stacked headings" are seen as bad in writing for a number of reasons. If a number of topics are related under a heading, then there should be some relationship that can explain them. If they are unrelated then we should question if they belong under the same heading. We can also inform the reader what is in this section without them having to refer to the index/table of contents so they know what will be covered in this section. And finally, if you click on a heading, and immediately go to another heading then why not just go straight there? So I tried to add some headings as I saw fit and hopefully you're OK with them. The one I did struggle with was "Meta" as wasn't use what this section was about (hence why an intro paragraph explaining it would be good! 😀) but went with:
With added emphasis on how just for you! 😁
I do to a point, however I think the sentence gets that point across without the need of this emphasis particularly on all three words - the meaning is totalling apparent with the sentence. If you read the sentence out loud, and emphasis all three words you'll be quote out of breath by the end of the sentence. We use italics to emphasis a new term, and very sparingly for emphasis. I left a few of those in, and added a few back in the last edit after re-reviewing, but honestly don't think it's needed in the above sentence. And bold is a very strong emphasis - like shouting it. So it should be used very, very sparingly IMHO.
I used to be with you on this and when I wrote my book I capitalised this for the reason you give but had so succumb to the publishers style guide on this. However I've changed my mind on this recently. The web is now a common, indicative part of our lives it no longer needs proper noun status in my mind and many style guides are changing to this (including the AP style guide. But there's definitely still some debate about this and it does upset some people. At the end of the day, both are used, and I think consistency is more important, and lowercase is what we've used in other chapters.
This one really surprised me and I actually looked it up as part of this copy edit and added it to our style guide. The Google Style Guide we use, says it uses this standard because that's what the W3C say! As some of you are in with them maybe we could get some definitive answers from them! I guess it is CSS and not CS which is one argument 😀 But it does seem to me that even then it's not clear cut: Doing a Google for So let's change here and use "stylesheet" without a space. It's what I would have used personally until I looked this up, and you backing this too convinced me. We didn't really have this standardised before (as I say I only looked it up as part of this copyedit) and doing a search the spaceless version is far more common in our codebase. Will update our style guide. |
I think this is good to merge now, so will do that before next release unless I hear back from you on anything. |
Progress on #1432 and #898
Made the following changes: