-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy 2020 queries #1129
Privacy 2020 queries #1129
Conversation
Be sure to update this from "Draft" to "Ready for review" so we can get more eyes on it |
Hi @max-ostapenko can you give us an update on the status of this chapter's analysis? Are there only 2 queries? |
@max-ostapenko how's this one coming along? Do you need any help? |
@rviscomi I lost my billing account last week by accident so have wasted a couple of days to get a new free trial credit. |
@max-ostapenko How are the queries coming along? Is this something you think you can finish this week? |
@max-ostapenko how is this analysis coming along? This is the last week to get the analysis in. |
Hi @max-ostapenko. Checking in again on this PR. Do you think you can get this finished by the end of the day today? @ydimova you've also expressed an interest in contributing to the analysis, are you able to help complete the remaining queries? |
@rviscomi visualised half of the queries. And finishing CMPs and trackers stats. |
Hi @max-ostapenko, I've made some changes to the chart in the first sheet so that desktop and mobile are shown as separate series/colors: Note that I hid the cell with the column name of the percentage to avoid it showing up in the chart with its raw SQL name. Could you copy/paste that chart to the other sheets to retain the same formatting, and update them with the new sheets' data? When do you expect to have the remaining queries implemented and ready for review? I'm very concerned about this chapter meeting the December 9 deadline given that it's been blocked on analysis for a while. |
@rviscomi still need some time to identify how to make a query on top of EasyList. |
Is this the list? https://easylist.to/easylist/easylist.txt The way I'd do it would be to parse the list in JS and generate something that can be processed by SQL, like an array of objects. The prefixes also look significant but I'm not sure what they mean. They can be fields of the object, for example: |
@max-ostapenko here you can find an overview of the different rules and what they mean https://adblockplus.org/forum/viewtopic.php?t=7702&start=0. We could make a list of regex expressions for instance if we can parse the rules correctly. |
There are also ~3k known ad domains in the SELECT
domain AS host
FROM
`httparchive.almanac.third_parties`
WHERE
date = '2020-08-01' AND
category = 'ad' You could join those with |
Can you merge |
…hive.org into privacy-sql-2020
@max-ostapenko @ydimova can you give a status update on this analysis? Friendly reminder that we're launching in ~2 weeks |
I'm going to merge these queries as-is and any changes can be applied in a follow-up PR. |
Progress on #913
Online tracking
Cookies
Privacy policies